Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715794 - net-irc/inspircd: Doesn't start on fresh install (did not create a valid pid)
Summary: net-irc/inspircd: Doesn't start on fresh install (did not create a valid pid)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wade Cline
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-01 19:21 UTC by Sam James
Modified: 2020-04-09 13:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_715794.txt,6.05 KB, text/plain)
2020-04-01 19:21 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-04-01 19:21:22 UTC
Created attachment 628542 [details]
emerge --info

On a fresh install, =net-irc/inspircd-3.4.0.
/run/inspircd does not exist.

# /etc/init.d/inspircd start
 * Caching service dependencies ...                                                                                                                                       [ ok ]
 * /run/inspircd: creating directory
 * /run/inspircd: correcting owner
 * Starting InspIRCd ...
 * start-stop-daemon: did not create a valid pid in `/run/inspircd/inspircd.pid'
 * Failed to start InspIRCd                                                                                                                                               [ !! ]
 * ERROR: inspircd failed to start
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-04-01 19:23:16 UTC
(In reply to Sam James (sam_c) (security padawan) from comment #0)
> On a fresh install, =net-irc/inspircd-3.4.0.
> /run/inspircd does not exist.

/run/inspircd does exist, it just can't create the pid.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-04-01 19:25:22 UTC
Fixed by setting:
><pid file="/run/inspircd/inspircd.pid">
in inspircd.conf.
Comment 3 Wade Cline 2020-04-05 21:55:11 UTC
So, traditionally (in the 2.x series), the default InspIRCd configuration had 'die' statements that would kill the process unless you had explicitly commented them out; this was to ensure that users had actually configured the daemon before launching it.  When I inherited the ebuild, the 'die' statements were still included in the install configuration file, thus I didn't see the default configuration file failing to be an issue.  The 'die' statements were removed in the 3.x series (though one still exists in the 'opers.conf' file), so, imo, it makes more sense to have a working default config (but one really ought to go over it).

The PR thus uncomments the PID file location in the default configuration file as per your request.
Comment 4 Larry the Git Cow gentoo-dev 2020-04-09 12:38:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a4b4829293214623d204c84dabacc9fff7723f6

commit 3a4b4829293214623d204c84dabacc9fff7723f6
Author:     Wade T. Cline <wadecline@hotmail.com>
AuthorDate: 2020-04-05 21:26:53 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-04-09 12:37:45 +0000

    net-irc/inspircd: Create valid PID by default
    
    Closes: https://bugs.gentoo.org/715794
    Signed-off-by: Wade Cline <wadecline@hotmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/15242
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-irc/inspircd/files/inspircd-3.4.0-fix-path-builds.patch | 4 ++--
 net-irc/inspircd/files/inspircd-3.5.0-fix-path-builds.patch | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-04-09 13:01:50 UTC
(In reply to Wade Cline from comment #3)
> So, traditionally (in the 2.x series), the default InspIRCd configuration
> had 'die' statements that would kill the process unless you had explicitly
> commented them out; this was to ensure that users had actually configured
> the daemon before launching it.  When I inherited the ebuild, the 'die'
> statements were still included in the install configuration file, thus I
> didn't see the default configuration file failing to be an issue.  The 'die'
> statements were removed in the 3.x series (though one still exists in the
> 'opers.conf' file), so, imo, it makes more sense to have a working default
> config (but one really ought to go over it).
> 
> The PR thus uncomments the PID file location in the default configuration
> file as per your request.

I was surprised to see them gone!

Thanks for that, I was in a rush to get an IRCd up and running as I was testing out Anope. Usually packages patch the PID so I just didn't think. Worth having a valid path anyway.

Thanks again.