Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708966 - media-sound/exaile: needs py3 port
Summary: media-sound/exaile: needs py3 port
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: py3-tracker, python-3-incompatible 719420
  Show dependency tree
 
Reported: 2020-02-10 11:37 UTC by Michał Górny
Modified: 2020-08-11 08:45 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
exaile-4.1.0_alpha1.ebuild (file_708966.txt,1.93 KB, text/plain)
2020-08-03 09:03 UTC, Wicher Minnaard
Details
files/exaile-4.1.0_alpha1-metainfo.patch (file_708966.txt,1.44 KB, text/plain)
2020-08-03 09:04 UTC, Wicher Minnaard
Details
Diff between exaile-4.0.0-r1.ebuild and exaile-4.1.0_alpha1.ebuild (file_708966.txt,1.38 KB, patch)
2020-08-03 09:16 UTC, Wicher Minnaard
Details | Diff
exaile-4.1.0_alpha1.ebuild (file_708966.txt,1.90 KB, text/plain)
2020-08-03 09:19 UTC, Wicher Minnaard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-02-10 11:37:34 UTC
This is the last package requiring py2 gst-python, and therefore colliding with all other packages using gst-python (it's single-r1).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-02-17 09:44:56 UTC
Apparently upstream master supports py3 these days.  Might be in our release already.
Comment 2 Mart Raudsepp gentoo-dev 2020-03-09 12:35:05 UTC
4.1.0-alpha1 was released with initial py3 support; probably good idea to at least wait for a rc, if not final; I'd hope upstream does that soonish
Comment 3 Mart Raudsepp gentoo-dev 2020-03-09 12:36:15 UTC
that said, gst-python is NOT single-r1
Comment 4 Wicher Minnaard 2020-08-03 09:03:47 UTC
Created attachment 652584 [details]
exaile-4.1.0_alpha1.ebuild

Minimal changes from exaile-4.0.0-r1.ebuild . Patch to follow.
Needs a patch to the Makefile (to follow).
Comment 5 Wicher Minnaard 2020-08-03 09:04:55 UTC
Created attachment 652586 [details]
files/exaile-4.1.0_alpha1-metainfo.patch

Patch to Makefile as referenced from exaile-4.1.0_alpha1.ebuild.
Comment 6 Wicher Minnaard 2020-08-03 09:16:59 UTC
Created attachment 652588 [details, diff]
Diff between exaile-4.0.0-r1.ebuild	and exaile-4.1.0_alpha1.ebuild

- Dropped PYTHON_REQ_USE="sqlite" - The Exaile music DB is of BerkeleyDB type. There is not a single .sqlite DB is in my ~/.local/share/exaile. That said, I haven't tested whether it'll work without sqlite support in python (who knows, perhaps it uses a :mem: in-memory sqlite database in some code path). Yet I think this might be in here since for a brief moment (years ago) exaile switched to a sqlite database backend, so this PYTHON_REQ_USE="sqlite" could be a vestigal remnant of that event.

- remove cddb use flag; cddb-py is python2.7 only, someone who's very enthusiastic about CDs could make the effort of making all that work again.

- add a patch to the Makefile; otherwise portage complains (warns) about XDG appdata -> metainfo nomenclature.
Comment 7 Wicher Minnaard 2020-08-03 09:19:20 UTC
Created attachment 652590 [details]
exaile-4.1.0_alpha1.ebuild
Comment 8 Christian Strahl 2020-08-04 07:54:07 UTC
(In reply to Wicher Minnaard from comment #7)
> Created attachment 652590 [details]
> exaile-4.1.0_alpha1.ebuild

ebuild works for me.

Since the file https://github.com/exaile/exaile/blob/master/DEPS list python-3.6 as a minimum requirement, I'd prefer to include at least python-3.6 in PYTHON_COMPAT:
PYTHON_COMPAT=( python3_{6,7} )
I don't expect any problems with python3_{8,9} either, but I haven't tested it.
Comment 9 Nikolay Kichukov 2020-08-11 07:58:54 UTC
Can the alpha ebuild be added to the portage tree, as the only version in there is marked for removal:

!!! The following installed packages are masked:
- media-sound/exaile-4.0.0-r1::gentoo (masked by: package.mask)
/usr/portage/profiles/package.mask:
# Aaron Bauman <bman@gentoo.org> (2020-08-01)
# Py2 only. Last upstream release 2013.
# Removal in 30 days. Last 2 have deps on cddb.

Thanks!
Comment 10 Larry the Git Cow gentoo-dev 2020-08-11 08:45:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=171803227f3ded10b76442406583c55e3b04c0ec

commit 171803227f3ded10b76442406583c55e3b04c0ec
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-08-11 08:42:09 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-08-11 08:45:24 +0000

    media-sound/exile: bump to 4.1.0_alpha1 + added live + dropped py2
    
    based on updated ebuild provided by Wicher Minnaard <wicher@gavagai.eu>
    
    Closes: https://bugs.gentoo.org/708966
    Package-Manager: Portage-3.0.2, Repoman-2.3.23
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/exaile/Manifest                        |  2 +-
 ...-4.0.0-r1.ebuild => exaile-4.1.0_alpha1.ebuild} | 44 ++++++-------
 media-sound/exaile/exaile-9999.ebuild              | 72 ++++++++++++++++++++++
 .../files/exaile-4.1.0_alpha1-metainfo.patch       | 29 +++++++++
 4 files changed, 120 insertions(+), 27 deletions(-)