Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706310 - dev-python/flake8-3.7.9: Test suite needs distutils_install_for_testing()
Summary: dev-python/flake8-3.7.9: Test suite needs distutils_install_for_testing()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-25 15:28 UTC by Kasey Banco
Modified: 2020-10-02 13:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
use distutils_install_for_testing() in python_test() (file_706310.txt,953 bytes, patch)
2020-01-25 15:28 UTC, Kasey Banco
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kasey Banco 2020-01-25 15:28:25 UTC
Created attachment 604256 [details, diff]
use distutils_install_for_testing() in python_test()

The test suite of dev-python/flake8 does not use the flake8 which is about to get merged but instead uses the old version already installed on the system.

This behaviour can be experienced when running the test suite of flake8-3.7.9 with dev-python/pycodestyle-2.5.0 and the old flake8-3.5.0 installed. In this situation the tests fail due to the incompatibility of flake8-3.5.0 and pycodestyle-2.5.0 (see [1]), which is fixed in >=flake8-3.6.0.

To make the test suite use the flake8 version which is about to be merged, distutils_install_for_testing() [2] should be used in python_test() before running the test suite.

A diff is attached which can be applied to flake8-3.7.9.ebuild.

[1] https://github.com/PyCQA/pycodestyle/issues/741
[2] https://wiki.gentoo.org/wiki/Project:Python/distutils-r1#distutils_install_for_testing
Comment 1 Larry the Git Cow gentoo-dev 2020-10-02 13:08:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=374ffcd390ba715c76bc69084eca4abae42c512d

commit 374ffcd390ba715c76bc69084eca4abae42c512d
Author:     Louis Sautier <sbraz@gentoo.org>
AuthorDate: 2020-10-02 12:32:12 +0000
Commit:     Louis Sautier <sbraz@gentoo.org>
CommitDate: 2020-10-02 13:08:22 +0000

    dev-python/flake8: bump to 3.8.3, fix tests, re-add doc
    
    Closes: https://bugs.gentoo.org/706310
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Louis Sautier <sbraz@gentoo.org>

 dev-python/flake8/Manifest                         |  1 +
 dev-python/flake8/files/flake8-3.8.3-pytest6.patch | 40 ++++++++++++++++++
 dev-python/flake8/flake8-3.8.3.ebuild              | 47 ++++++++++++++++++++++
 3 files changed, 88 insertions(+)