Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695592 - kernel-2.eclass does not respect USE=symlink
Summary: kernel-2.eclass does not respect USE=symlink
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-09-24 21:59 UTC by Bertrand Jacquin
Modified: 2021-06-07 11:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bertrand Jacquin 2019-09-24 21:59:46 UTC
kernel-2 eclass postinst_sources() creates /usr/usr/linux symlink
regardless of USE=symlink. MAKELINK variable controls the creation
of /usr/src/linux, however MAKELINK is always set to 1 only if
/usr/src/linux does not currently exist with no consideration for
USE=symlink.


Note that this is broken since 626ceb860869 ("Multiple fixes.")

Pull Request to fix the issue: https://github.com/gentoo/gentoo/pull/13031

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2021-06-07 11:59:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa4f1706fe35d8e49c69f3cd1c1caf66f3a0714d

commit aa4f1706fe35d8e49c69f3cd1c1caf66f3a0714d
Author:     Bertrand Jacquin <bertrand@jacquin.bzh>
AuthorDate: 2019-09-24 21:42:00 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2021-06-07 11:58:43 +0000

    eclass/kernel-2: respect USE=symlink
    
    kernel-2 eclass postinst_sources() creates /usr/usr/linux symlink
    regardless of USE=symlink. MAKELINK variable controls the creation
    of /usr/src/linux, however MAKELINK is always set to 1 only if
    /usr/src/linux does not currently exist with no consideration for
    USE=symlink.
    
    This change simplify the whole /usr/usr/linux symlink creation to
    instead depend on K_SYMLINK which is set if USE=symlink.
    
    This change also refuse to remove existing /usr/usr/linux if it
    currently exist while not being a symlink
    
    Note that this is broken since 906501be57c0 ("adding symlink use flag
    support")
    
    Bug: https://bugs.gentoo.org/695592
    Signed-off-by: Bertrand Jacquin <bertrand@jacquin.bzh>
    Closes: https://bugs.gentoo.org/695592
    Closes: https://github.com/gentoo/gentoo/pull/13031
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 eclass/kernel-2.eclass | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa4f1706fe35d8e49c69f3cd1c1caf66f3a0714d

commit aa4f1706fe35d8e49c69f3cd1c1caf66f3a0714d
Author:     Bertrand Jacquin <bertrand@jacquin.bzh>
AuthorDate: 2019-09-24 21:42:00 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2021-06-07 11:58:43 +0000

    eclass/kernel-2: respect USE=symlink
    
    kernel-2 eclass postinst_sources() creates /usr/usr/linux symlink
    regardless of USE=symlink. MAKELINK variable controls the creation
    of /usr/src/linux, however MAKELINK is always set to 1 only if
    /usr/src/linux does not currently exist with no consideration for
    USE=symlink.
    
    This change simplify the whole /usr/usr/linux symlink creation to
    instead depend on K_SYMLINK which is set if USE=symlink.
    
    This change also refuse to remove existing /usr/usr/linux if it
    currently exist while not being a symlink
    
    Note that this is broken since 906501be57c0 ("adding symlink use flag
    support")
    
    Bug: https://bugs.gentoo.org/695592
    Signed-off-by: Bertrand Jacquin <bertrand@jacquin.bzh>
    Closes: https://bugs.gentoo.org/695592
    Closes: https://github.com/gentoo/gentoo/pull/13031
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 eclass/kernel-2.eclass | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)