Bug 694012 – gnome2-utils.eclass: gnome2_gconf_install(), gnome2_gconf_uninstall(), gnome2_gdk_pixbuf_update(), gnome2_query_immodules_gtk2() and gnome2_query_immodules_gtk3() broken in EAPI 7

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis 2019-09-11 04:02:13 UTC]

${D}, ${ED}, ${ROOT} and ${EROOT} do not end with "/" in EAPI 7.


gnome2_gdk_pixbuf_update() contains:
  cp -f "${tmp_file}" "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache"


gnome2_query_immodules_gtk2() contains:
  GTK_IM_MODULE_FILE="${EROOT}usr/$(get_libdir)/gtk-2.0/2.10.0/immodules.cache" \
    "${updater}" --update-cache


gnome2_query_immodules_gtk3() contains:
  GTK_IM_MODULE_FILE="${EROOT}usr/$(get_libdir)/gtk-3.0/3.0.0/immodules.cache" \
    "${updater}" --update-cache

[Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-09-11 04:11:01 UTC]

gnome2_gconf_savelist() sets GNOME2_ECLASS_SCHEMAS with value not starting with "/":
  export GNOME2_ECLASS_SCHEMAS=$(find 'etc/gconf/schemas/' -name '*.schemas' 2> /dev/null)


gnome2_gconf_install() is missing "/" in:
  for F in ${GNOME2_ECLASS_SCHEMAS}; do
    if [[ -e "${EROOT}${F}" ]]; then

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-09-11 05:49:01 UTC]

Created attachment 589682 [details, diff]
Patch

[Comment 3 Mart Raudsepp 2019-09-18 06:03:52 UTC]

Please post this to gentoo-dev review as I've asked multiple times on IRC.

[Comment 4 Shiba 2019-10-20 11:39:43 UTC]

I just wanted to add that gnome2_gdk_pixbuf_update() requires emktemp, which is part of eutils.eclass, but it doesn't get inherited for EAPI 7.

[Comment 5 Mart Raudsepp 2019-10-20 12:11:35 UTC]

Yeah, had to revert to EAPI-6 in gdk-pixbuf due to that.
Otherwise still waiting for OP to post them to gentoo-dev..

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2020-03-31 18:57:44 UTC]

Created attachment 628072 [details, diff]
Patch

[Comment 7 Larry the Git Cow 2020-04-07 20:54:00 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=410a9670ed9e55034a05118a8cb30561c904d1be

commit 410a9670ed9e55034a05118a8cb30561c904d1be
Author:     Arfrever Frehtes Taifersar Arahesis <[e-mail]>
AuthorDate: 2020-03-31 20:06:10 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2020-04-07 20:53:47 +0000

    gnome2-utils.eclass: Inherit eutils.eclass for emktemp().
    
    Bug: https://bugs.gentoo.org/694012
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <[e-mail]>
    Signed-off-by: Matt Turner <[e-mail]>

 eclass/gnome2-utils.eclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0974a38af3c214814c703b50f310cf629529373

commit f0974a38af3c214814c703b50f310cf629529373
Author:     Arfrever Frehtes Taifersar Arahesis <[e-mail]>
AuthorDate: 2020-03-31 20:06:09 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2020-04-07 20:53:47 +0000

    gnome2-utils.eclass: Fix missing "/" with EAPI >= 7.
    
    Bug: https://bugs.gentoo.org/694012
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <[e-mail]>
    Signed-off-by: Matt Turner <[e-mail]>

 eclass/gnome2-utils.eclass | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8be00fd2295b99388f2ffd2b44182e00b0eb3aa4

commit 8be00fd2295b99388f2ffd2b44182e00b0eb3aa4
Author:     Arfrever Frehtes Taifersar Arahesis <[e-mail]>
AuthorDate: 2020-03-31 20:06:08 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2020-04-07 20:53:47 +0000

    gnome2-utils.eclass: Fix double "/" with EAPI < 7.
    
    Bug: https://bugs.gentoo.org/694012
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <[e-mail]>
    Signed-off-by: Matt Turner <[e-mail]>

 eclass/gnome2-utils.eclass | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)