Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 68522 - K3b 0.11.17, errors in ebuild (fix suggested)
Summary: K3b 0.11.17, errors in ebuild (fix suggested)
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-22 03:33 UTC by Federico Zenith
Modified: 2004-10-26 03:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Corrected K3b ebuild (k3b-0.11.17.ebuild,3.39 KB, text/plain)
2004-10-22 03:34 UTC, Federico Zenith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Federico Zenith 2004-10-22 03:33:41 UTC
Hi,
there are a few subtle mistakes in K3b's ebuild. First, there is no Italian documentation (there is a directory but it's empty), and if one has a "it" in LINGUAS a crash should ensue.

Another problem is the way the MAKE_PO and MAKE_DOC variables are found; for instance, MAKE_PO is:
MAKE_PO=$(echo "${LINGUAS} ${LANGS}" | fmt -w 1 | sort | uniq -d)

This will result, if there are more than 1 language, in a vertical list; in my case,

it
fr
de

This will give a number of problems, as the sed calls based on MAKE_PO and MAKE_DOC will be terminated early. The typical effect will be a invalid sed call, and missing SUBDIRS correction. Probably this problem was not previously detected due to the fact that there are really few people with 6 languages in their LINGUAS (err...).

Solution is to pipe in fmt one more time, and things work out nice.
Comment 1 Federico Zenith 2004-10-22 03:34:06 UTC
Created attachment 42409 [details]
Corrected K3b ebuild
Comment 2 Antonio 2004-10-24 06:03:34 UTC
Same problem;
k3b with LINGUAS=it does not install
Comment 3 Simone Gotti (RETIRED) gentoo-dev 2004-10-25 03:10:24 UTC
Thanks for reporting this:

I've tested your changes and they works, I made only a little one:
used 'fmt -w 10000' instead of 'fmt' or if the line is greater then 75 chars (if someone wants all the languages for example) it will break to a new one (with the same problem as before).

kde-other herds, if there aren't problems, I'll commit the change for the 0.11.17 ebuild, let me know.
Comment 4 Simone Gotti (RETIRED) gentoo-dev 2004-10-26 01:44:41 UTC
Committed in CVS.
Comment 5 Federico Zenith 2004-10-26 03:53:43 UTC
Confirming spotting in portage, closing bug.