Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683050 - =sci-mathematics/rstudio-1.2.1335 version bump
Summary: =sci-mathematics/rstudio-1.2.1335 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mark Wright
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 686186
  Show dependency tree
 
Reported: 2019-04-10 17:24 UTC by Neil
Modified: 2019-08-21 14:08 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated version of the pandoc patch (rstudio-1.2.1355-clang-pandoc.patch,2.83 KB, patch)
2019-04-25 09:33 UTC, François Valenduc
Details | Diff
current version of my ebuild (rstudio-1.2.1335.ebuild,8.03 KB, text/plain)
2019-04-25 09:33 UTC, François Valenduc
Details
rstudio-1.2.1335.ebuild (rstudio-1.2.1335.ebuild,8.08 KB, text/plain)
2019-05-06 18:42 UTC, Thomas Bettler
Details
rstudio-1.2.1335-qtsingleapplication.patch (rstudio-1.2.1335-qtsingleapplication.patch,2.00 KB, patch)
2019-05-06 18:43 UTC, Thomas Bettler
Details | Diff
patch for java preferences (rstudio-1.2.1335-prefs.patch,1.63 KB, patch)
2019-06-11 14:13 UTC, François Valenduc
Details | Diff
rstudio-1.2.1335-paths.patch (rstudio-1.2.1335-paths.patch,5.85 KB, patch)
2019-06-11 18:10 UTC, Thomas Bettler
Details | Diff
patch for build with boost-1.70 (rstudio-1.2.1335-boost-1.70.patch,2.28 KB, patch)
2019-06-22 06:14 UTC, Simon Maurer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neil 2019-04-10 17:24:59 UTC
New version realeased with significant improvements, see announcement at...

https://www.rstudio.com/products/rstudio/release-notes/

I've not tried bumping locally as I don't use it (stuck with Emacs + ESS) but know that others find it useful but am aware that it has been difficult getting the ebuild working in the past
Comment 1 François Valenduc 2019-04-20 06:54:41 UTC
I have tried to make an ebuild for this version by copying the one for version 1.1.463. I first had to remove all patches, except the one related to systemd (1.0.44-systemd.patch). All the others do not apply anymore.
Then I tried to compile it but it fails with an error about pandoc:

CMake Error at src/cpp/session/CMakeLists.txt:29 (message):
  pandoc not found (re-run install-dependencies script to install)

grep 'PANDOC_VERSION=' dependencies/common/install-pandoc seems to indicate that version 2.3.1 is needed, but is not available in portage. I tried to make an ebuild for pandoc for this version but it didn't work. I ended up with problems with pando-citeproc, texmath and tagsoup.
Comment 2 Neil 2019-04-23 12:27:51 UTC
Thanks for having a go at this.

I found #645082 which is for a version bump of Pandoc (originally for 2.1.1 but recently bumped to 2.7.1), but it appears to still have a few problems.
Comment 3 Ulenrich 2019-04-24 11:09:53 UTC
Now http://pandoc.org/releases.html shows app-text/pandoc-2.7.2
But: 
dev-haskell/pandoc-citeproc depends on pandoc whith this:
RDEPEND=">=app-text/pandoc-1.16:=[profile?] <app-text/pandoc-2.1:=[profile?]

For me it is like dependency hell, so I resort on haskell overlay
which seems taking care of that.
Comment 4 François Valenduc 2019-04-25 09:31:52 UTC
I managed to install pandoc 2.3.1 from the haskell overlay. Then I updated the patch "rstudio-1.1.357-clang-pandoc.patch". It now fails with an error related to qt. I think this version needs qt 5.12 which is available in portage, but not yet stable.
Comment 5 François Valenduc 2019-04-25 09:32:21 UTC
Here is the error:

-- Configuring done
CMake Error at src/cpp/desktop/CMakeLists.txt:363 (add_executable):
  Cannot find source file:

    3rdparty/qtsingleapplication/qtsingleapplication.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx


-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    DISTRO_SHARE
Comment 6 François Valenduc 2019-04-25 09:33:35 UTC
Created attachment 574102 [details, diff]
updated version of the pandoc patch
Comment 7 François Valenduc 2019-04-25 09:33:59 UTC
Created attachment 574104 [details]
current version of my ebuild
Comment 8 Ulenrich 2019-04-29 16:01:24 UTC
Arrrght, just installed qt-5.12
Now I am hung in the middle, the Gentoorstudio-1.1.463 did not recompile, at 63%
---
x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libQt5Network.so.5.12.3: warning: EVP_CipherFinal is often misused, please
use EVP_CipherFinal_ex and EVP_CIPHER_CTX_cleanup
make[2]: Leaving directory '/srv/portage/sci-mathematics/rstudio-1.1.463/work/rstudio-1.1.463_build'
[ 63%] Built target rstudio
make[1]: Leaving directory '/srv/portage/sci-mathematics/rstudio-1.1.463/work/rstudio-1.1.463_build'
make: *** [Makefile:152: all] Error 2
---
@Francois Thanx for your work, I will  try with that to rescue upgrade rstudio
Comment 9 Ulenrich 2019-05-01 22:23:15 UTC
(In reply to François Valenduc from comment #5)
> -- Configuring done
> CMake Error at src/cpp/desktop/CMakeLists.txt:363 (add_executable):
>   Cannot find source file:
> 
>     3rdparty/qtsingleapplication/qtsingleapplication.cpp
> 
>   Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
>   .hxx .in .txx

@Francois
I have the same error with your provided ebuild. I had a look and diffed to the previous version of the Gentoo ebuild:
You did remove most the patches. Probably the didn't fit any more. 
BUT:
There is a "sed" command in the src-prepare section, and in the Comment of it is stated:
# dev-qt/qtsingleapplication-2.6.1_p20150629 does not provide a cmake module.
# It provides a library that has its version number appended to the end,
# which is difficult to handle in cmake, as find_library does not support
# searching for wildcard library names. So I find the library name from the
# qmake spec, and then sed this into the patched src/cpp/desktop/CMakeLists.txt.

THUS:
The following "sed" command only functions and delivers the needed 
qtsingleapplication 
IF: 
the applicated patch rstudio-0.99.473-qtsingleapplication.patch
makes some noise for sed to find. Without "sed" never applicates its medicine!
Comment 10 Ulenrich 2019-05-01 22:46:35 UTC
Also to be included in an updated ebuild are these DEPEND:
    dev-qt/qtpositioning
    dev-qt/qtwebengine[widgets]
old:dev-qt/qtquickcontrols[widgets]
or: dev-qt/qtquickcontrols2[widgets]  <- I don't know
or: dev-qt/qtwidget                   <- And -or- OR
Comment 11 Ulenrich 2019-05-01 22:52:10 UTC
Also there might be needed a new sed command to adjust the search for the Qt versions. Found this in src/cpp/desktop/CMakeLists.txt:
       set(QT_CANDIDATES 5.12.1 5.10.1)
Comment 12 Thomas Bettler 2019-05-06 18:42:00 UTC
Created attachment 575424 [details]
rstudio-1.2.1335.ebuild

thanks for all your comments

rstudio-1.2.1335.ebuild
compiles fine here
Comment 13 Thomas Bettler 2019-05-06 18:43:14 UTC
Created attachment 575426 [details, diff]
rstudio-1.2.1335-qtsingleapplication.patch
Comment 14 Ulenrich 2019-05-07 09:08:02 UTC
@Thomas 
I am not so lucky: The installed newest boost-1.70 fails it
boost::asio
...
Comment 15 Thomas Bettler 2019-05-07 17:34:35 UTC
@Ulenrich, did you try with boost 1.65? - want to provide some errorlog?
Comment 16 Thomas Bettler 2019-05-07 17:37:44 UTC
(In reply to Thomas Bettler from comment #15)
> @Ulenrich, did you try with boost 1.65? - want to provide some errorlog?

you may report your bug upstream:
https://github.com/rstudio/rstudio/issues/4467
https://github.com/rstudio/rstudio/issues/4636
Comment 17 François Valenduc 2019-05-14 07:42:53 UTC
I get this at the end of the compilation:

     [java] Compiling module org.rstudio.studio.RStudio
 * ACCESS DENIED:  open_wr:      /root/.java/.userPrefs/.user.lock.root
 * ACCESS DENIED:  open_wr:      /root/.java/.userPrefs/.user.lock.root
 * ACCESS DENIED:  open_wr:      /root/.java/.userPrefs/.user.lock.root
 * ACCESS DENIED:  open_wr:      /root/.java/.userPrefs/.user.lock.root
 * ACCESS DENIED:  open_wr:      /root/.java/.userPrefs/.user.lock.root
     [java] Exception in thread "Timer-0" java.lang.SecurityException: Could not lock User prefs. Lock file access denied.
     [java]     at java.util.prefs.FileSystemPreferences.checkLockFile0ErrorCode(FileSystemPreferences.java:937)
     [java]     at java.util.prefs.FileSystemPreferences.lockFile(FileSystemPreferences.java:925)
     [java]     at java.util.prefs.FileSystemPreferences.sync(FileSystemPreferences.java:729)
     [java]     at java.util.prefs.FileSystemPreferences.flush(FileSystemPreferences.java:824)
     [java]     at java.util.prefs.FileSystemPreferences.syncWorld(FileSystemPreferences.java:464)
     [java]     at java.util.prefs.FileSystemPreferences.access$1200(FileSystemPreferences.java:50)
     [java]     at java.util.prefs.FileSystemPreferences$3.run(FileSystemPreferences.java:432)
     [java]     at java.util.TimerThread.mainLoop(Timer.java:555)
     [java]     at java.util.TimerThread.run(Timer.java:505)

It seems to compile correctly however.
Comment 18 François Valenduc 2019-06-11 13:17:57 UTC
For me it doesn't compile if I do not add addpredict  /root/.java/.userPrefs in the ebuild.
Furthermore, this ebuild installs files in /usr. There are now folders like www, symbolmaps, R in /usr.
Can somebody explain this ?
Comment 19 François Valenduc 2019-06-11 14:13:47 UTC
Created attachment 579532 [details, diff]
patch for java preferences

The problem with java preferences problem can be solved with this patch.
Comment 20 Thomas Bettler 2019-06-11 18:10:43 UTC
Created attachment 579554 [details, diff]
rstudio-1.2.1335-paths.patch

(In reply to François Valenduc from comment #18)
> Furthermore, this ebuild installs files in /usr. There are now folders like
> www, symbolmaps, R in /usr.

Try this updated patch
Comment 21 Simon Maurer 2019-06-22 06:14:49 UTC
Created attachment 580338 [details, diff]
patch for build with boost-1.70

Not tested beyond compiling
Comment 22 Bernd Feige 2019-07-12 07:27:38 UTC
This has become more urgent now that boost-1.70 is officially unmasked in the tree and current rstudio is blocking it with "<dev-libs/boost-1.70:=". Somehow portage fails to just hold the update back and so boost and boost-build 1.70 need to be masked by hand...
Comment 23 Ulenrich 2019-07-12 17:04:21 UTC
(In reply to Bernd Feige from comment #22)
> This has become more urgent now that boost-1.70 is officially unmasked in
> the tree and current rstudio is blocking it with "<dev-libs/boost-1.70:=".
As of my earlier tries:
rstudio-1.2.1335 not is ready for boost-1.70 also
Comment 24 Andreas Sturmlechner gentoo-dev 2019-07-21 08:51:57 UTC
(In reply to Ulenrich from comment #23)
> As of my earlier tries:
> rstudio-1.2.1335 not is ready for boost-1.70 also
same with the latest patch attached in this bug?
Comment 25 Bernd Feige 2019-07-21 16:02:49 UTC
(In reply to Andreas Sturmlechner from comment #24)
> (In reply to Ulenrich from comment #23)
> > As of my earlier tries:
> > rstudio-1.2.1335 not is ready for boost-1.70 also
> same with the latest patch attached in this bug?

I pulled all patches above now and compiled 1.2.1335. In fact it did not compile with boost-1.65.0 (missed a library call at ~65%) but compiled without problems against boost-1.70.0 and also works nicely so far.

The dependency upon pandoc-2 had to be lifted, because that is not in the tree (need the Haskell overlay for that). RStudio didn't complain but it could be that some conversion functionality will be missing.
Comment 26 Mark Wright gentoo-dev 2019-08-20 13:28:41 UTC
Thanks for the help.  My 10 year old machine is very slow, I created the patches for this back on mar 30 and apr 9 then I got distracted trying to build a faster machine.  Its seems to be compiling, I need to figure out the GLEP 81 user stuff.
Comment 27 Larry the Git Cow gentoo-dev 2019-08-21 14:08:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cdda9adf72b626d020a063419c1f376755d1b456

commit cdda9adf72b626d020a063419c1f376755d1b456
Author:     Mark Wright <gienah@gentoo.org>
AuthorDate: 2019-08-21 14:03:46 +0000
Commit:     Mark Wright <gienah@gentoo.org>
CommitDate: 2019-08-21 14:03:46 +0000

    sci-mathematics/rstudio: Bump to 1.2.1335, fix compile with >=boost 1.70.0
    
    Bump, thanks to Neil, Ulenrich, François Valenduc, Thomas Bettler,
    Simon Maurer, Bernd Feige and asturm for helping.
    
    Split the rstudio-1.1.463-boost-1.69.0_p?.patch patches into 3 patch files.
    
    Closes: https://bugs.gentoo.org/683050
    Closes: https://bugs.gentoo.org/686186
    Package-Manager: Portage-2.3.71, Repoman-2.3.17
    Signed-off-by: Mark Wright <gienah@gentoo.org>

 sci-mathematics/rstudio/Manifest                   |   3 +
 .../files/rstudio-1.1.463-boost-1.69.0_p1.patch    | 222 +-----------
 .../files/rstudio-1.1.463-boost-1.69.0_p2.patch    | 377 ++++++++++++---------
 .../files/rstudio-1.1.463-boost-1.69.0_p3.patch    | 167 +++++++++
 .../files/rstudio-1.1.463-boost-1.70.0.patch       |  46 +++
 .../files/rstudio-1.2.1335-boost-1.70.0_p1.patch   |  46 +++
 .../files/rstudio-1.2.1335-boost-1.70.0_p2.patch   |  17 +
 .../rstudio/files/rstudio-1.2.1335-core.patch      | 160 +++++++++
 .../rstudio-1.2.1335-fix-ptr-int-compare.patch     |  13 +
 .../files/rstudio-1.2.1335-linker_flags.patch      |  11 +
 .../rstudio/files/rstudio-1.2.1335-pandoc.patch    |  32 ++
 .../rstudio/files/rstudio-1.2.1335-paths.patch     | 118 +++++++
 .../rstudio/files/rstudio-1.2.1335-prefs.patch     |  53 +++
 .../rstudio-1.2.1335-qtsingleapplication.patch     |  60 ++++
 sci-mathematics/rstudio/rstudio-1.1.463-r1.ebuild  | 255 ++++++++++++++
 sci-mathematics/rstudio/rstudio-1.1.463.ebuild     |   1 +
 sci-mathematics/rstudio/rstudio-1.2.1335.ebuild    | 253 ++++++++++++++
 17 files changed, 1451 insertions(+), 383 deletions(-)