Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 680916 - >=sys-kernel/gentoo-sources-4.19.28 - arch/x86/events/core.c: In function ‘free_fake_cpuc’: arch/x86/events/core.c:1998:20: error: passing argument 1 of ‘intel_cpuc_finish’ from incompatible pointer type [-Werror=incompatible-pointer-types]
Summary: >=sys-kernel/gentoo-sources-4.19.28 - arch/x86/events/core.c: In function ‘fr...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords: PATCH
: 680926 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-03-19 02:36 UTC by brankob
Modified: 2019-07-17 11:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
my .config file (.config,130.19 KB, text/plain)
2019-03-19 02:38 UTC, brankob
Details
patch (my_output212.patch,419 bytes, patch)
2019-03-19 09:51 UTC, brankob
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description brankob 2019-03-19 02:36:57 UTC
It fails with an error report, listed under "actual results".

If I change the line in the main MAkefile:
"HOSTCC       = gcc"

into 

"HOSTCC       = gcc -Wno-error=incompatible-pointer-types"

it compiles fine 




Reproducible: Always

Actual Results:  
arch/x86/events/core.c: In function ‘free_fake_cpuc’:
arch/x86/events/core.c:1998:20: error: passing argument 1 of ‘intel_cpuc_finish’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  intel_cpuc_finish(cpuc);
                    ^~~~
In file included from arch/x86/events/core.c:44:
arch/x86/events/perf_event.h:1040:59: note: expected ‘struct cpu_hw_event *’ but argument is of type ‘struct cpu_hw_events *’
 static inline void intel_cpuc_finish(struct cpu_hw_event *cpuc)
                                      ~~~~~~~~~~~~~~~~~~~~~^~~~
arch/x86/events/core.c: In function ‘allocate_fake_cpuc’:
arch/x86/events/core.c:2012:25: error: passing argument 1 of ‘intel_cpuc_prepare’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  if (intel_cpuc_prepare(cpuc, cpu))
                         ^~~~



will attach my config file...
Comment 1 brankob 2019-03-19 02:38:02 UTC
Created attachment 569748 [details]
my .config file
Comment 2 brankob 2019-03-19 07:58:57 UTC
Erm, make that version 4.19.29 and later

version 4.19.28 and previous  still work...
Comment 3 brankob 2019-03-19 09:51:02 UTC
Created attachment 569752 [details, diff]
patch

this seems to fix it
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-19 12:33:42 UTC
*** Bug 680926 has been marked as a duplicate of this bug. ***
Comment 5 Georgy Yakovlev archtester gentoo-dev 2019-03-19 19:48:33 UTC
fixed in 4.19.30 which hit tree couple of hrs ago

commit a8eae05f8dbf9e05ce27e5ad77c338e266834512
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Fri Mar 15 09:14:10 2019 +0100

    perf/x86: Fixup typo in stub functions
    
    commit f764c58b7faa26f5714e6907f892abc2bc0de4f8 upstream.
    
    Guenter reported a build warning for CONFIG_CPU_SUP_INTEL=n:
    
      > With allmodconfig-CONFIG_CPU_SUP_INTEL, this patch results in:
      >
      > In file included from arch/x86/events/amd/core.c:8:0:
      > arch/x86/events/amd/../perf_event.h:1036:45: warning: ‘struct cpu_hw_event’ declared inside parameter list will not be visible outside of this definition or declaration
      >  static inline int intel_cpuc_prepare(struct cpu_hw_event *cpuc, int cpu)
    
    While harmless (an unsed pointer is an unused pointer, no matter the type)
    it needs fixing.
    
    Reported-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: stable@vger.kernel.org
    Fixes: d01b1f96a82e ("perf/x86/intel: Make cpuc allocations consistent")
    Link: http://lkml.kernel.org/r/20190315081410.GR5996@hirez.programming.kicks-ass.net
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>