Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678348 - sys-devel/prelink - /etc/cron.daily/prelink complains when it inspects /sbin/init without first checking to see whether it exists
Summary: sys-devel/prelink - /etc/cron.daily/prelink complains when it inspects /sbin/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-02-19 06:18 UTC by Enne Eziarc
Modified: 2019-08-23 06:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
use `prelink -p` instead of `ldd` in prelink.cron (prelink.cron.patch,1.37 KB, patch)
2019-02-19 06:18 UTC, Enne Eziarc
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enne Eziarc 2019-02-19 06:18:54 UTC
Created attachment 565814 [details, diff]
use `prelink -p` instead of `ldd` in prelink.cron

The cron script introspects /sbin/init without first checking to see whether it exists, leading to cron email spam when it doesn't.

Enclosed is a patch that reads prelink's own cache file instead. A minor side benefit is that there's no more need to silence errors to hack around the presence of linux-vdso in the list.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2019-02-19 22:03:09 UTC
The patch looks reasonable. Rest of code uses absolute path to 'prelink' binary.

Are you familiar with git to attach something I can just 'git am'?
While at it i suggest splitting patch in two:
1. patch to consolidate logic into one helper. straightforward, candidate to apply instantly.
2. patch to query prelink cache. I'm a bit nervous about it and would like to explore stability of 'prelink -p' output.
Comment 2 Larry the Git Cow gentoo-dev 2019-08-23 06:49:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1be2b4aae769dc42b8dee38ebac5439458207ff

commit d1be2b4aae769dc42b8dee38ebac5439458207ff
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-08-23 06:48:10 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-08-23 06:49:01 +0000

    sys-devel/prelink: ignore warnings from 'ldd /sbin/init'
    
    /sbin/init might not exist at all. Let's not generate
    text output in this case.
    
    Reported-by: Anthony Parsons
    Closes: https://bugs.gentoo.org/678348
    Package-Manager: Portage-2.3.72, Repoman-2.3.17
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/prelink/files/prelink.cron | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)