Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 677756 - kernel-2.eclass: LICENSE is not accurate for kernel 4.14 and later
Summary: kernel-2.eclass: LICENSE is not accurate for kernel 4.14 and later
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: https://git.kernel.org/pub/scm/linux/...
Whiteboard:
Keywords:
Depends on:
Blocks: 676248
  Show dependency tree
 
Reported: 2019-02-11 20:54 UTC by Ulrich Müller
Modified: 2019-02-15 19:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch for kernel-2.eclass (kernel-2.eclass.diff,938 bytes, patch)
2019-02-11 20:54 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2019-02-11 20:54:37 UTC
Created attachment 564846 [details, diff]
Proposed patch for kernel-2.eclass

Starting with version 4.14, the whole firmware tree has been dropped from the kernel (see URL). Therefore including "linux-firmware" in LICENSE is no longer accurate.

See attachment for a suggested patch.
Comment 1 Mike Pagano gentoo-dev 2019-02-12 14:14:14 UTC
(In reply to Ulrich Müller from comment #0)
> Created attachment 564846 [details, diff] [details, diff]
> Proposed patch for kernel-2.eclass
> 
> Starting with version 4.14, the whole firmware tree has been dropped from
> the kernel (see URL). Therefore including "linux-firmware" in LICENSE is no
> longer accurate.
> 
> See attachment for a suggested patch.

Ulm, thanks for the patch. lgtm.  I pinged Alicef on IRC for visibility.  I'll let her comment if she wants, but I think we can merge this one.

I'll run a few tests on my side.
Comment 2 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2019-02-12 23:56:40 UTC
lgtm too
Comment 3 Larry the Git Cow gentoo-dev 2019-02-15 19:57:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf5243d1f881c0086cf7fb08fb7cb65f417a31a5

commit cf5243d1f881c0086cf7fb08fb7cb65f417a31a5
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2019-02-13 07:31:15 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2019-02-15 19:56:36 +0000

    kernel-2.eclass: Fix LICENSE for Linux 4.14 and later.
    
    Starting with version 4.14, the whole firmware tree has been dropped
    from the kernel:
    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b38923a068c10fc36ca8f596d650d095ce390b85
    Therefore including "linux-firmware" in LICENSE is no longer accurate.
    
    Closes: https://bugs.gentoo.org/677756
    Reviewed-by: Mike Pagano <mpagano@gentoo.org>
    Reviewed-by: Alice Ferrazzi <alicef@gentoo.org>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eclass/kernel-2.eclass | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)