666647 – sys-process/cronie-1.5.2: [fbsd] env.c:145:17: error: ‘environ’ undeclared

Bug 666647 - sys-process/cronie-1.5.2: [fbsd] env.c:145:17: error: ‘environ’ undeclared

Summary: sys-process/cronie-1.5.2: [fbsd] env.c:145:17: error: ‘environ’ undeclared

Status:	RESOLVED OBSOLETE

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All FreeBSD

Importance:	Normal normal (vote)
Assignee:	Lars Wendler (Polynomial-C) (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	497394
	Show dependency tree

Reported:	2018-09-20 17:42 UTC by Michał Górny
Modified:	2019-10-12 12:17 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
sys-process:cronie-1.5.2:20180920-173702.log (sys-process:cronie-1.5.2:20180920-173702.log,10.13 KB, text/plain) 2018-09-20 17:42 UTC, Michał Górny	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2018-09-20 17:42:15 UTC

Created attachment 547425 [details]
sys-process:cronie-1.5.2:20180920-173702.log

x86_64-gentoo-freebsd11.1-gcc -DHAVE_CONFIG_H -I. -I..    -I.. -O2 -pipe -march=native -c -o env.o env.c
env.c: In function ‘env_set_from_environ’:
env.c:145:17: error: ‘environ’ undeclared (first use in this function)
  for (procenv = environ; *procenv != NULL; ++procenv) {
                 ^~~~~~~
env.c:145:17: note: each undeclared identifier is reported only once for each function it appears in
gmake[3]: *** [Makefile:492: env.o] Error 1

Comment 1 Michał Górny archtester

2018-09-20 17:44:07 UTC

I'm going to guess it expects '--enable-bsd'.

Comment 2 Michał Górny archtester

2018-09-20 17:49:28 UTC

Hm, or that doesn't help, apparently.

Comment 3 Michał Górny archtester

2018-09-20 17:56:06 UTC

Uncommenting that 'environ' declaration from '#ifdef BSD' block makes it pass but it fails afterwards trying to use execvpe() which is not available on FreeBSD.

Comment 4 Mike Gilbert gentoo-dev

2018-09-20 18:04:12 UTC

(In reply to Michał Górny from comment #3)
> Uncommenting that 'environ' declaration from '#ifdef BSD' block makes it
> pass but it fails afterwards trying to use execvpe() which is not available
> on FreeBSD.

Looks like exect() would be the FreeBSD equivalent of execvpe().

Comment 5 Mike Gilbert gentoo-dev

2018-09-20 18:05:38 UTC

(In reply to Mike Gilbert from comment #4)
> Looks like exect() would be the FreeBSD equivalent of execvpe().

Never mind; that doesn't search PATH.

Comment 6 Larry the Git Cow gentoo-dev

2018-09-20 21:05:03 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fd44962557b7870ac34c9b64f9bcfefc508f1e0

commit 0fd44962557b7870ac34c9b64f9bcfefc508f1e0
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-09-20 20:53:39 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-09-20 21:01:35 +0000

    Revert "profiles/package.mask: mask sys-process/vixie-cron for removal"
    
    This reverts commit 7d730131a1bd6a49a049c82241ae463659b9e22e.
    
    Reverted to satisfy dependencies of sys-freebsd/freebsd-sbin for now
    because proposed replacement package sys-process/cronie don't build on
    amd64-fbsd (yet).
    
    Bug: https://bugs.gentoo.org/666647

 profiles/package.mask | 6 ------
 1 file changed, 6 deletions(-)

Comment 7 Michał Górny archtester

2019-10-12 12:17:32 UTC

G/FBSD is dead.