659742 – app-portage/gpyutils-0.2.1: gpy-upgrade-impl python3_5 python3_6 doesn't catch sys-boot/grub

Bug 659742 - app-portage/gpyutils-0.2.1: gpy-upgrade-impl python3_5 python3_6 doesn't catch sys-boot/grub

Summary: app-portage/gpyutils-0.2.1: gpy-upgrade-impl python3_5 python3_6 doesn't catc...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Mike Gilbert

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-07-01 07:46 UTC by Pacho Ramos
Modified:	2021-06-20 17:59 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pacho Ramos gentoo-dev

2018-07-01 07:46:42 UTC

Hi!

This morning I saw bug 659734 and I noticed that gpy-upgrade-impl doesn't catch it
# gpy-upgrade-impl python3_5 python3_6
app-misc/jira-cli:0
app-office/libreoffice-bin:0
app-portage/gentoolkit-dev:0
app-portage/gs-pypi:0
dev-python/pyrtf:0
dev-python/translate-toolkit:0
kde-apps/lokalize:5
net-misc/whatportis:0
Done.

I am not sure if maybe the if with GRUB_AUTOGEN is causing this to not be detected

Thanks

Comment 1 Michał Górny archtester

2018-07-01 17:51:41 UTC

It's because of [[ ${PV} == 9999 ]] logic.  PYTHON_COMPAT is read via a poor man's bash parser that doesn't set PV, so the PYTHON_COMPAT branch is never executed.

This could be fixed by moving PYTHON_COMPAT outside the if.