Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 657668 - media-sound/mp3info fails to compile with format-security
Summary: media-sound/mp3info fails to compile with format-security
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: fortify-source
  Show dependency tree
 
Reported: 2018-06-09 19:23 UTC by Azamat H. Hackimov
Modified: 2018-06-22 22:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Azamat H. Hackimov 2018-06-09 19:23:28 UTC
>>> Compiling source in /var/tmp/portage/media-sound/mp3info-0.8.5a/work/mp3info-0.8.5a ...
make -j4 mp3info gmp3info CC=x86_64-pc-linux-gnu-gcc 'CFLAGS=-march=native -O2 -pipe -Wformat -Werror=format-security' 
x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -Wformat -Werror=format-security   -c -o mp3info.o mp3info.c
x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -Wformat -Werror=format-security   -c -o textfunc.o textfunc.c
x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -Wformat -Werror=format-security   -c -o mp3curs.o mp3curs.c
x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -Wformat -Werror=format-security   -c -o mp3tech.o mp3tech.c
textfunc.c: In function ‘format_output’:
textfunc.c:230:3: error: format not a string literal and no format arguments [-Werror=format-security]
   printf(format);
   ^~~~~~
textfunc.c:357:2: error: format not a string literal and no format arguments [-Werror=format-security]
  printf(format);
  ^~~~~~

emerge --info:
Portage 2.3.40 (python 3.5.5-final-0, default/linux/amd64/17.0/desktop/plasma, gcc-6.4.0, glibc-2.26-r7, 4.14.48-gentoo x86_64)
=================================================================
System uname: Linux-4.14.48-gentoo-x86_64-Intel-R-_Core-TM-_i3-4130_CPU_@_3.40GHz-with-gentoo-2.4.1
KiB Mem:     8103428 total,   1105528 free
KiB Swap:   12582908 total,  12582908 free
Head commit of repository gentoo: e58a13b98eaff04d81cf5b9c9dc4a28a34eddb88

sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.5.5::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.15.1-r2::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo, 2.30-r2::gentoo
sys-devel/gcc:            6.4.0-r1::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://github.com/gentoo/gentoo.git
    priority: -1000

iceland
    location: /home/winterheart/gentoo-ru/iceland
    masters: gentoo
    priority: 0

im-mond
    location: /home/winterheart/gentoo-ru/im-mond
    masters: gentoo
    priority: 1

gamerlay
    location: /home/winterheart/gentoo-ru/gamerlay
    masters: gentoo
    priority: 2

rion
    location: /home/winterheart/gentoo-ru/rion-overlay
    masters: gentoo
    priority: 3

steam-overlay
    location: /var/lib/layman/steam-overlay
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -Wformat -Werror=format-security"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/redmine/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /var/lib/redmine/config/locales /var/lib/redmine/config/settings.yml"
CXXFLAGS="-march=native -O2 -pipe -Wformat -Werror=format-security"
DISTDIR="/usr/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms sign splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/"
LANG="ru_RU.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="ru ru_RU en"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 apng aspell avahi bash-completion berkdb bluetooth bluray branding bzip2 cairo calendar cdaudio cdda cdr cg cleartype cli consolekit crypt cups cxx dbus declarative dri dts dvd dvdr dvdread egl emboss encode exif fam ffmpeg flac fontconfig fts3 g3dvl gcrypt gdbm gif glamor gnutls gpm gtk gtk3 hunspell iconv initramfs ipv6 jingle jpeg jpeg2k kde kipi kwallet lcms libass libnotify libtirpc lm_sensors lzma lzo mad mdnsresponder-compat midi mikmod minizip mjpeg mng mod modules mp2 mp3 mp4 mpeg mpeg2 mplayer mtp multilib music musicbrainz ncurses nls nptl nsplugin nss ntfs nvenc nvidia ofx ogg openal openexr opengl openmp pam pango pcre pcre16 pdf phonon plasma pm-utils png policykit ppds projectm pulseaudio qml qt3support qt5 rdp readline rtc sdl seccomp semantic-desktop sha512 slp smp sound spell srt ssl startup-notification svg tcpd templates theora threads tiff timidity truetype udev udisks unicode upnp upower usb uvm vdpau vim-syntax vlc vorbis vpx wavpack webkit widgets win32codecs wxwidgets x264 xattr xcb xcomposite xine xml xpm xscreensaver xulrunner xv xvid zeroconf zip zlib" ABI_X86="32 64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="worker" CALLIGRA_FEATURES="krita" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" L10N="ru ru_RU en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5 python3_6" RUBY_TARGETS="ruby22 ruby23" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Larry the Git Cow gentoo-dev 2018-06-22 22:17:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a64e78259432a21caae85b633496331235377130

commit a64e78259432a21caae85b633496331235377130
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2018-06-09 19:26:36 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-06-22 22:17:11 +0000

    media-sound/mp3info: patch against printf format issue.
    
    Closes: https://bugs.gentoo.org/657668
    
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    Closes: https://github.com/gentoo/gentoo/pull/8771

 .../files/mp3info-0.8.5a-format-security.patch     | 21 +++++++++++
 media-sound/mp3info/mp3info-0.8.5a-r1.ebuild       | 41 ++++++++++++++++++++++
 2 files changed, 62 insertions(+)