Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654466 - app-emulation/wine-{any,staging}: Remove dependency on media-libs/libtxc_dxtn
Summary: app-emulation/wine-{any,staging}: Remove dependency on media-libs/libtxc_dxtn
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 654464
  Show dependency tree
 
Reported: 2018-05-01 07:11 UTC by Matt Turner
Modified: 2019-09-16 22:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2018-05-01 07:11:33 UTC
Presumably this dependency was simply to ensure it was installed so Mesa drivers would support S3TC, and not an actual dependency of WINE itself.

libtxc_dxtn is now integrated in Mesa, so the dependency is unnecessary (presumably) and media-libs/libtxc_dxtn is being given last rites. Please remove the dependency.
Comment 1 Nick Sarnie gentoo-dev 2018-05-02 01:39:37 UTC
Hey Matt,

As you suggested, it looks like libtxc_dxtn is not required in WINE itself, and that it was used to make sure Mesa supported S3TC. As the dependency has been essentially no-op since support was added universally upstream, and that change is in stable on all supported arches, I agree we can drop it.

I'm just double-checking with NP-Hardass, and I'll drop the dependency once I hear from him.

Thanks,
Sarnex
Comment 2 Nick Sarnie gentoo-dev 2018-05-02 01:52:36 UTC
Update: I swung and missed.

This is a staging only feature, and it does directly link against libtxc_dxtn. You can find the patch in question below:

https://github.com/wine-staging/wine-staging/blob/master/patches/wined3d-DXTn/0001-wined3d-Add-support-for-DXTn-software-decoding-throu.patch


It looks like the part that loads and uses libtxc_dxtn.so needs to be rewritten before we can drop it.

I will email the wine-staging devs about this.

Sarnex
Comment 3 Nick Sarnie gentoo-dev 2018-05-06 19:14:48 UTC
I am actively working on this. I have a working patch from the staging guys. Now, I just need to backport it (manually) to every version of wine-staging and wine-any in the wine project repo, and then push the changes to ::gentoo


Sarnex
Comment 4 Matt Turner gentoo-dev 2018-10-09 16:11:00 UTC
I think this is fixed? I don't see any libtxc_dxtn deps in app-emulation/wine-{any,staging} anymore.
Comment 5 Nick Sarnie gentoo-dev 2018-10-09 22:12:08 UTC
Hi Matt,

So the problem is the wine overlay has wine ebuilds back pretty far, which still has dependencies on it.

https://gitweb.gentoo.org/repo/proj/wine.git/

I don't know if we can remove libtxc_dxtn from the tree given this.

Thanks,

Sarnex
Comment 6 Matt Turner gentoo-dev 2019-09-16 21:42:28 UTC
(In reply to Nick Sarnie from comment #5)
> Hi Matt,
> 
> So the problem is the wine overlay has wine ebuilds back pretty far, which
> still has dependencies on it.
> 
> https://gitweb.gentoo.org/repo/proj/wine.git/
> 
> I don't know if we can remove libtxc_dxtn from the tree given this.

I'd suggest moving libtxc_dxtn to the wine repo if that's all that requires it.

With bug 654470 progressing, I suspect that will be the situation soon.
Comment 7 Larry the Git Cow gentoo-dev 2019-09-16 22:25:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=534e003eec465ce77580d157d4e4de62d103b038

commit 534e003eec465ce77580d157d4e4de62d103b038
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2019-09-16 22:25:25 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2019-09-16 22:25:25 +0000

    media-libs/libtxc_dxtn: Add to ::wine
    
    Fixes: https://bugs.gentoo.org/show_bug.cgi?id=654466
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 media-libs/libtxc_dxtn/Manifest                    |  1 +
 media-libs/libtxc_dxtn/libtxc_dxtn-1.0.1-r4.ebuild | 29 ++++++++++++++++++++++
 media-libs/libtxc_dxtn/metadata.xml                |  8 ++++++
 3 files changed, 38 insertions(+)
Comment 8 Nick Sarnie gentoo-dev 2019-09-16 22:26:23 UTC
No wine ebuilds in ::gentoo need it, so I moved libtxc_dxtn to ::wine as suggested