Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 650430 - =media-sound/hydrogen-1.0.0_pre20180301 patch file hydrogen-gnuinstalldirs.patch uses wrong CMAKE variable name for installation
Summary: =media-sound/hydrogen-1.0.0_pre20180301 patch file hydrogen-gnuinstalldirs.pa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL: https://cmake.org/cmake/help/v3.10/mo...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-13 19:08 UTC by PhobosK
Modified: 2018-03-13 19:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
hydrogen-gnuinstalldirs.patch.diff (hydrogen-gnuinstalldirs.patch.diff,2.50 KB, patch)
2018-03-13 19:08 UTC, PhobosK
Details | Diff
hydrogen-gnuinstalldirs.patch (hydrogen-gnuinstalldirs.patch,4.39 KB, patch)
2018-03-13 19:09 UTC, PhobosK
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PhobosK 2018-03-13 19:08:22 UTC
Created attachment 523806 [details, diff]
hydrogen-gnuinstalldirs.patch.diff

The patch (hydrogen-gnuinstalldirs.patch) applied to the CMAKE files of =media-sound/hydrogen-1.0.0_pre20180301 (and also of the live ebuild) uses wrong name of the CMAKE variable CMAKE_INSTALL_FULL_<dir> . The name in the patch is: CMAKE_FULL_INSTALL_<dir> thus installing most of the data files of hydrogen (incl. man, desktop file etc) in the root folder (/) and polluting the root file system...

I am uploading a diff file for the patch and the fixed patch....
CC-ing the author (and the committer in portage tree) of the patch, so this can be resolved faster :) 

Tested and works OK on ~amd64

Thanks
Comment 1 PhobosK 2018-03-13 19:09:57 UTC
Created attachment 523808 [details, diff]
hydrogen-gnuinstalldirs.patch

The whole fixed patch though I am sure the author doesn't need this ;)
Comment 2 Larry the Git Cow gentoo-dev 2018-03-13 19:17:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=342c44e9545350abc429cbd44185d4012afbab6a

commit 342c44e9545350abc429cbd44185d4012afbab6a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-03-13 19:14:49 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-03-13 19:17:16 +0000

    media-sound/hydrogen: Fix cmake-patch
    
    Thanks-to: PhobosK <phobosk@fastmail.fm>
    Closes: https://bugs.gentoo.org/650430
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 ...patch => hydrogen-1.0.0_pre20180301-gnuinstalldirs.patch} | 12 ++++++------
 ...e20180301.ebuild => hydrogen-1.0.0_pre20180301-r1.ebuild} |  2 +-
 media-sound/hydrogen/hydrogen-9999.ebuild                    |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)