Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 647914 - app-crypt/sbsigntool-0.8 with >=dev-libs/openssl-1.1.0 - sbverify.c:126:25: error: dereferencing pointer to incomplete type ‘X509 {aka struct x509_st}’
Summary: app-crypt/sbsigntool-0.8 with >=dev-libs/openssl-1.1.0 - sbverify.c:126:25: e...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: openssl-1.1
  Show dependency tree
 
Reported: 2018-02-17 04:29 UTC by Quentin Minster
Modified: 2018-07-07 21:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_647914.txt,18.89 KB, text/plain)
2018-02-17 04:29 UTC, Quentin Minster
Details
sbsigntools-0.9.1-openssl-1.1.0-compat.patch (sbsigntools-0.9.1-openssl-1.1.0-compat.patch,4.62 KB, patch)
2018-02-17 04:30 UTC, Quentin Minster
Details | Diff
sbsigntool-0.9.1.ebuild (sbsigntool-0.9.1.ebuild,1.40 KB, text/plain)
2018-02-17 04:31 UTC, Quentin Minster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Minster 2018-02-17 04:29:35 UTC
Created attachment 519862 [details]
build.log

app-crypt/sbsigntool-0.8 fails to build with >=dev-libs/openssl-1.1.0, with errors regarding dereferencing pointers to incomplete types, and several warnings about using undeclared functions.

This is due to changes in OpenSSL 1.1.0: internal structures are now opaque, and a lot of functions were deprecated/removed.

Upstream has a new version (0.9.1, see [0]) with some fixes for OpenSSL 1.1.0.
However a simple version bump is not enough, there are still some calls to undeclared functions and a missing include, so the build still fails.

I'm attaching 2 things below:
* a patch against sbsigntools-0.9.1 that restores compatibility with Gentoo's OpenSSL 1.1.0 (this has been sent upstream)
* an ebuild for sbsigntool-0.9.1 that bumps to EAPI 6, removes banned/unused eclasses, and uses upstream's 0.9.1 snapshot tarball instead of a Gentoo-hosted one


[0]: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/sbsigntools.git/
Comment 1 Quentin Minster 2018-02-17 04:30:34 UTC
Created attachment 519864 [details, diff]
sbsigntools-0.9.1-openssl-1.1.0-compat.patch
Comment 2 Quentin Minster 2018-02-17 04:31:17 UTC
Created attachment 519866 [details]
sbsigntool-0.9.1.ebuild
Comment 3 Conrad Kostecki gentoo-dev 2018-04-20 14:00:58 UTC
Quentin, do you want here also be proxy maintainer? I think, that would make sense, since you also want to proxy maintain app-crypt/efitools.
Comment 4 Larry the Git Cow gentoo-dev 2018-06-29 04:02:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=871179913c778d4f66d9c4f5f5a70cb93b3c97b0

commit 871179913c778d4f66d9c4f5f5a70cb93b3c97b0
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-06-29 03:56:15 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-06-29 04:01:39 +0000

    app-crypt/sbsigntool: version bump to 0.9.1
    
     * version bump to 0.9.1
     * use new upstream repository
     * openssl-1.1.0 patches, thanks to Quentin Minster
     * multiple compilation fixes
    
    Closes: https://bugs.gentoo.org/647914
    Closes: https://bugs.gentoo.org/652094
    Closes: https://bugs.gentoo.org/629992
    Closes: https://bugs.gentoo.org/632068
    Closes: https://bugs.gentoo.org/657648
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 app-crypt/sbsigntool/Manifest                      |   1 +
 .../sbsigntool-0.9.1-openssl-1.1.0-compat.patch    | 152 +++++++++++++++++++++
 app-crypt/sbsigntool/sbsigntool-0.8.ebuild         |   2 +-
 app-crypt/sbsigntool/sbsigntool-0.9.1.ebuild       |  52 +++++++
 4 files changed, 206 insertions(+), 1 deletion(-)