Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 638644 - media-plugins/gst-plugins-cdio-1.12.3 with dev-libs/libcdio-1.0.0 - Dans la fonction « gst_cdio_add_cdtext_field »: .../work/gst-plugins-ugly-1.12.3/ext/cdio/gstcdio.c:55:27: error: type incompatible pour l'argument 1 de « cdtext_get_const »
Summary: media-plugins/gst-plugins-cdio-1.12.3 with dev-libs/libcdio-1.0.0 - Dans la ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-24 00:02 UTC by Denis Descheneaux
Modified: 2017-12-18 19:39 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,50.14 KB, text/plain)
2017-11-24 00:02 UTC, Denis Descheneaux 		Details
emerge --info (info.txt,28.34 KB, text/plain)
2017-11-24 00:15 UTC, Denis Descheneaux 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Descheneaux 2017-11-24 00:02:29 UTC 
Created attachment 506234 [details]
build.log

!!! existing preserved libs:
>>> package: dev-libs/libcdio-1.0.0

 *  - /usr/lib32/libcdio.so.16
 *  - /usr/lib32/libcdio.so.16.0.0
 *      used by /usr/lib32/gstreamer-1.0/libgstcdio.so (media-plugins/gst-plugins-cdio-1.12.3)
 *      used by /usr/lib32/libvcdinfo.so.0.2.0 (media-video/vcdimager-0.7.24)
 *  - /usr/lib64/libcdio.so.16
 *  - /usr/lib64/libcdio.so.16.0.0
 *      used by /usr/bin/cdxa2mpeg (media-video/vcdimager-0.7.24)
 *      used by /usr/bin/vcd-info (media-video/vcdimager-0.7.24)
 *      used by /usr/bin/vcdimager (media-video/vcdimager-0.7.24)
 *      used by 8 other files

Fail to preserve-rebuild after upgrade to dev-libs/libcdio-1.0.0
Comment 1 Denis Descheneaux 2017-11-24 00:15:29 UTC 
Created attachment 506246 [details]
emerge --info
Comment 2 Marien Zwart 2017-11-24 08:19:30 UTC 
This is the same issue as bug 638630 in gvfs. libcdio's version went backwards.

First error:

/var/tmp/portage/media-plugins/gst-plugins-cdio-1.12.3/work/gst-plugins-ugly-1.12.3/ext/cdio/gstcdio.c:55:27: error: incompatible type for argument 1 of ‘cdtext_get_const’
   txt = cdtext_get_const (field, cdtext);                                                                                                                                                                             
                           ^~~~~    
              
That means we took the "old" branch here:

#if LIBCDIO_VERSION_NUM > 83                                                                                                                                                                                                                   
  txt = cdtext_get_const (cdtext, field, track);                                                                                                                                                                                               
#else                                                                                                                                                                                                                                          
  txt = cdtext_get_const (field, cdtext);                                                                                                                                                                                                      
#endif                                                                                                                                                                                                                                         

That's because /usr/include/x86_64-pc-linux-gnu/cdio/version.h has:

#define LIBCDIO_VERSION_NUM 1

while previously it had:

#define LIBCDIO_VERSION_NUM 94

So the version number went backwards, breaking gst-plugins-cdio (and gvfs) version detecting code.
Comment 3 Marien Zwart 2017-11-24 08:24:54 UTC 
See also upstream bug https://savannah.gnu.org/bugs/?52491

Sounds like the next version of libcdio will go back to a more sensible version macro.
Comment 4 Xavier Miller (RETIRED) gentoo-dev 2017-11-24 10:08:13 UTC 
Same problem for kodi, gvfs
Comment 5 Larry the Git Cow gentoo-dev 2017-11-24 14:13:02 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba52139c96a39f6f2285edb173af960a2afb51fa

commit ba52139c96a39f6f2285edb173af960a2afb51fa
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2017-11-24 14:12:39 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2017-11-24 14:12:56 +0000

    dev-libs/libcdio: Revbump to fix LIBCDIO_VERSION_NUM breakage.
    
    Bug: https://bugs.gentoo.org/638644
    Package-Manager: Portage-2.3.16, Repoman-2.3.6

 dev-libs/libcdio/files/libcdio-1.0.0-version.patch       | 16 ++++++++++++++++
 .../{libcdio-1.0.0.ebuild => libcdio-1.0.0-r1.ebuild}    |  7 ++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)}
Comment 6 Denis Descheneaux 2017-11-24 16:26:37 UTC 
Builds successfully with latest revision of dev-libs/libcdio-1.0.0-r1
Comment 7 Denis Descheneaux 2017-11-24 17:50:21 UTC 
kodi also builds fine and gvfs as well (without the user patch)