Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633574 - sys-block/open-iscsi: iscsidev.sh is broken and useless
Summary: sys-block/open-iscsi: iscsidev.sh is broken and useless
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-05 18:46 UTC by Benjamin Gilbert
Modified: 2018-01-02 14:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Gilbert 2017-10-05 18:46:04 UTC
iscsidev.sh has a couple problems:

1. It doesn't run for all iSCSI devices, only those with a vendor string of "IET". Thus it works for e.g. tgtd but not for enterprise iSCSI targets.

2. When it decides not to do anything, it exits 1, producing a series of systemd-udevd log messages at boot:

    systemd-udevd[636]: Process '/usr/lib/udev/scripts/iscsidev.sh' failed with exit code 1.

iscsidev.sh and the corresponding udev rule were added to the ebuild in 2015. However, udev's path_id builtin has supported iSCSI targets -- resulting in exactly the same /dev/disk/by-path links -- since udev 143 in 2009. Thus, it doesn't appear that iscsidev.sh actually accomplishes anything, and bug 556632 and the commit https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=71ec964872431f7677d34e2a33803692e75e416a that added it are uninformative. Consider removing iscsidev.sh and the corresponding udev rule entirely.
Comment 1 Larry the Git Cow gentoo-dev 2018-01-02 14:54:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9278a10daad10aaedff21f2ca630570a1c0dacbe

commit 9278a10daad10aaedff21f2ca630570a1c0dacbe
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-01-02 14:01:56 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-01-02 14:53:57 +0000

    sys-block/open-iscsi: Rev bump to fix multiple issues
    
    Ebuild changes:
    ===============
    - Patch: Include sysmacros.h. [Bug 604442]
    
    - Install systemd service. [Bug 640598]
    
    - Remove deprecated iscsidev.sh udev rule in favor of udev native iSCSI
      support which is available since udev-143. [Bug 633574]
    
    - Drop "slp" USE flag. [Bug 558366]
    
    Bug: https://bugs.gentoo.org/558366
    Closes: https://bugs.gentoo.org/604442
    Closes: https://bugs.gentoo.org/640598
    Closes: https://bugs.gentoo.org/633574
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../open-iscsi-2.0.874-include-sysmacros.patch     |  20 ++++
 sys-block/open-iscsi/open-iscsi-2.0.874-r2.ebuild  | 122 +++++++++++++++++++++
 2 files changed, 142 insertions(+)