632650 – dev-libs/link-grammar-5.3.11 : define for fmaxf no longer needed on uclibc-ng

Bug 632650 - dev-libs/link-grammar-5.3.11 : define for fmaxf no longer needed on uclibc-ng

Summary: dev-libs/link-grammar-5.3.11 : define for fmaxf no longer needed on uclibc-ng

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	uclibc-porting
	Show dependency tree

Reported:	2017-10-01 20:06 UTC by René Rhéaume
Modified:	2021-04-16 15:14 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
link-grammar-5.3.11-uclibcng.patch (link-grammar-5.3.11-uclibcng.patch,807 bytes, patch) 2017-10-01 20:06 UTC, René Rhéaume	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description René Rhéaume 2017-10-01 20:06:50 UTC

Created attachment 497378 [details, diff]
link-grammar-5.3.11-uclibcng.patch

In bug #498472, as uclibc lacks fmaxf, a macro was added on a compiler define. The patch was integrated upstream. It was good until upstream decided to create a MAX macro used globally. The uclibc-specific fmaxf macro is now in the way and prevents build on uclibc-ng. The attached patch removed the now obsolete macro and replaces its call with a call to the MAX macro.

Comment 1 Matt Turner gentoo-dev

2021-04-16 15:14:40 UTC

This looks to have been fixed by https://github.com/opencog/link-grammar/commit/9d6c2e99daba6f6505faf3d57d13bd22389f6248 which was in link-grammar-5.5.1.