Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 631118 - x11-libs/libfm build error with recent vala compiler
Summary: x11-libs/libfm build error with recent vala compiler
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: LXDE team (DEFUNCT)
URL: https://github.com/lxde/libfm/commit/...
Whiteboard:
Keywords: PATCH
: 642036 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-09-16 12:06 UTC by Sander Sweers
Modified: 2019-05-15 15:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch from libfm git (libfm_vala_build_error.patch,623 bytes, patch)
2017-09-16 12:06 UTC, Sander Sweers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sander Sweers 2017-09-16 12:06:25 UTC
Created attachment 494744 [details, diff]
patch from libfm git

make[4]: Entering directory '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5/src/actions'
rm -f libfmactions_la_vala.stamp && echo stamp > libfmactions_la_vala.stamp-t
CDPATH="${ZSH_VERSION+.}:" && cd . && /usr/bin/valac-0.36 --thread --vapidir=./../vapi --pkg gio-2.0 --pkg posix --pkg libfm --vapi ./../vapi/fm-actions.vapi --header fm-actions.h   -C action.vala condition.vala profile.vala parameters.vala utils.vala
condition.vala:149.18-155.34: warning: unhandled error `GLib.Error'
condition.vala:192.8-193.40: warning: unhandled error `GLib.SpawnError'
action.vala:81.4-81.30: error: use `new' operator to create new objects
			FileAction.from_keyfile(kf);
			^^^^^^^^^^^^^^^^^^^^^^^^^^^
action.vala:144.4-144.34: error: use `new' operator to create new objects
			FileActionMenu.from_keyfile(kf);
			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
action.vala:185.28-185.31: warning: Argument 1: Cannot pass null to non-null parameter type
				cached_children.append(null);
				                       ^^^^
action.vala:177.8-177.82: warning: unhandled error `GLib.SpawnError'
				if(Process.spawn_command_line_sync(command, out output, null, out exit_status)
				   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
action.vala:238.21-238.24: warning: Argument 1: Cannot pass null to non-null parameter type
				children.append(null);
				                ^^^^
action.vala:334.10-334.40: warning: unhandled error `GLib.KeyFileError'
						if(kf.load_from_file(full_path, 0)) {
						   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 6 warning(s)
make[4]: *** [Makefile:599: libfmactions_la_vala.stamp] Error 1
make[4]: Leaving directory '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5/src/actions'
make[3]: *** [Makefile:2754: all-recursive] Error 1
make[3]: Leaving directory '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5/src'
make[2]: *** [Makefile:1130: all] Error 2
make[2]: Leaving directory '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5/src'
make[1]: *** [Makefile:567: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5'
make: *** [Makefile:469: all] Error 2
 * ERROR: x11-libs/libfm-1.2.5::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=x11-libs/libfm-1.2.5::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=x11-libs/libfm-1.2.5::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/x11-libs/libfm-1.2.5/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-libs/libfm-1.2.5/temp/environment'.
 * Working directory: '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5'
 * S: '/var/tmp/portage/x11-libs/libfm-1.2.5/work/libfm-1.2.5'
Comment 1 Sander Sweers 2017-09-16 12:07:33 UTC
ebuild diff

--- /usr/portage/x11-libs/libfm/libfm-1.2.5.ebuild	2017-02-28 20:50:50.000000000 +0100
+++ libfm-1.2.5.ebuild	2017-09-16 14:01:42.084549753 +0200
@@ -48,6 +48,10 @@
 	# https://github.com/lxde/libfm/pull/11/commits/9e3a809c6a8a5079f05e04edac9457d317822321
 	epatch "${FILESDIR}"/libfm-fix-use-after-free.diff
 
+	# Fix build error with vala 0.36.1
+	# https://github.com/lxde/libfm/commit/5d03c2d8dc5570e31d5a65c3b8fac97d5755fd36
+	epatch "${FILESDIR}"/libfm_vala_build_error.patch
+
 	if ! use doc; then
 		sed -ie '/^SUBDIR.*=/s#docs##' "${S}"/Makefile.am || die "sed failed"
 		sed -ie '/^[[:space:]]*docs/d' configure.ac || die "sed failed"
Comment 2 urcindalo 2018-07-06 10:56:46 UTC
Same error here, on stable amd64.

=====
$ eix -I vala
[I] dev-lang/vala
     Available versions:  
     (0.32) 0.32.1
     (0.34) 0.34.9 0.34.16
     (0.36) 0.36.13
       {test}
     Installed versions:  0.36.13(0.36)(12:40:01 06/07/18)(-test)
     Homepage:            https://wiki.gnome.org/Projects/Vala
     Description:         Compiler for the GObject type system

[I] dev-libs/vala-common
     Available versions:  0.34.9 ~0.34.16 0.36.7 ~0.36.11 0.36.13
     Installed versions:  0.36.13(09:08:13 27/04/18)
     Homepage:            https://wiki.gnome.org/Projects/Vala
     Description:         Build infrastructure for packages that use Vala

Found 2 matches

$ eix -I libfm
[I] x11-libs/libfm
     Available versions:  1.2.3-r1(0/4.3.0) 1.2.4(0/4.4.0) 1.2.5(0/4.5.0) **9999(0/4.4.0) {+automount debug doc examples exif gtk udisks vala}
     Installed versions:  1.2.5(14:04:25 20/06/18)(automount exif gtk udisks -debug -doc -examples -vala)
     Homepage:            http://pcmanfm.sourceforge.net/
     Description:         A library for file management

[I] x11-libs/libfm-extra
     Available versions:  1.2.3(0/4.3.0) 1.2.4(0/4.4.0) 1.2.5(0/4.5.0)
     Installed versions:  1.2.5(13:56:00 20/06/18)
     Homepage:            http://pcmanfm.sourceforge.net/
     Description:         A library for file management

[I] x11-libs/libfm-qt
     Available versions:  0.11.1(0/3)
     Installed versions:  0.11.1(14:05:17 20/06/18)
     Homepage:            https://lxqt.org
     Description:         Qt port of libfm, a library providing components to build desktop file managers

Found 3 matches
=====

These are the packages that would be merged, in reverse order:

Calculating dependencies... done!
[ebuild   R    ] x11-libs/libfm-1.2.5:0/4.5.0::gentoo  USE="automount exif gtk udisks vala* -debug -doc -examples" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB
=====
Comment 3 Egor 2018-08-04 12:58:17 UTC
i have same error
Comment 4 CaptainBlood 2018-11-19 18:50:53 UTC
same here
Comment 5 Sander Sweers 2018-11-19 19:06:42 UTC
Nobody cares that current stable is broken. I tried to raise this in irc some time ago, one bug I posted a patch for vala 0.36 got fixed but not this one. I  decided I don't care either so will ignore bugmail for this bug.
Comment 6 mimosinnet 2019-05-07 09:46:27 UTC
I confirm the same error occurs with libfm-1.2.5 and valac-0.40
Comment 7 Hanno Böck gentoo-dev 2019-05-15 14:38:07 UTC
*** Bug 642036 has been marked as a duplicate of this bug. ***
Comment 8 Hanno Böck gentoo-dev 2019-05-15 15:09:11 UTC
Resolved with bump to libfm 1.3.1.