Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 630882 - Please approve the backports of wiki GLEP changes
Summary: Please approve the backports of wiki GLEP changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Council
Classification: Unclassified
Component: unspecified (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Council
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 628098
  Show dependency tree
 
Reported: 2017-09-13 12:04 UTC by Michał Górny
Modified: 2017-10-08 20:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
glep-wiki-updates.tar.bz2 (glep-wiki-updates.tar.bz2,102.03 KB, application/x-bzip)
2017-09-18 17:50 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-13 12:04:28 UTC
Repository: https://github.com/mgorny/glep-draft
PR for convenience: https://github.com/mgorny/glep-draft/pull/1

I've converted the old CVS directory with GLEPs into git (master branch). I'd like the Council to review/approve the wiki-updates branch that contains:

1. conversion of GLEP-4 from GuideXML to ReST format,

2. updates to all 'old' GLEPs from wiki (using ReST markup).

Notes:
* All GLEPs except for 2 use ReST format. Since the sole purpose of GLEP-2 is to provide a specific markup template, I've used a temporary `text/x-wiki` format to preserve it in its exact form.

* I've tried to quasi-reliably preserve history from wiki but I've squashed some minor edits, especially wiki formatting changes that are irrelevant to the ReST representation.

* Most of the wiki sync commits include some changes. Those changes were merged directly into the wiki port, i.e. there is no intermediate wiki 'commit' between the original and altered form. Those changes include:
  * typo fixes,
  * license change from public-domain to CC,
  * some other editorial changes (needing review?).

* Most (all?) the changes were done by @creffett (I will verify the changelogs later). @creffett, would you prefer if I made you `GIT_COMMIT_AUTHOR` for those ports, or if I listed you as `Original-Author` in the commit message footers?

I've tried hard not to miss any changes but I might have missed something. The best way to compare the GLEPs with MW versions is to use `dev-util/dwdiff` with `-P -c` options. The MW versions are available directly on the `wiki` branch (created using git mediawiki remote).

---

Please note that this is not yet about the final approval of the GLEP process change. I will prepare updates of GLEP-1/2 for the new procedure later, and submit them for approval separately. This is mostly to confirm the changes made by GLEP editors during porting to wiki, and to review my backport.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-14 13:36:45 UTC
Small update: the branch now contains some more fixes to the old GLEPs from ulm, and backports of all the new GLEPs from wiki. In other words, it's ready for full review.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-18 17:50:53 UTC
Created attachment 495270 [details]
glep-wiki-updates.tar.bz2
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-18 17:59:52 UTC
Ok, here's a tarball with all the patches on top of cvs2git conversion which is now in the repo [1]. The patches include:

a. conversion of GLEP 4 from GuideXML to ReST format,

b. updates for all old GLEPs containing changes that were made on MediaWiki,

c. ports of the new GLEPs from MediaWiki to ReST format,

d. revert of GLEP 7 change (made by ulm) where GLEP editors have changed 'devrel' into 'ComRel' in the historical GLEP.


So this vote is about approving this conversion of GLEPs independently of the main vote on updating GLEP 1/2, i.e. deciding whether:

1) we agree with the changes made by GLEP editor on wiki (except for d. above which ulm reverted already);

2) we stamp the conversion as officially valid and correct in meaning.

The patches were reviewed by me and ulm but more eyes are always welcome. After looking through them, please vote on the bug.


Vote: "The Council approves the attached GLEP conversion as valid and accurate".


[1]:https://gitweb.gentoo.org/data/glep.git
Comment 4 Ulrich Müller gentoo-dev 2017-09-18 21:18:40 UTC
I have done three passes of comparison on the final version: First, comparing the Mediawiki and RST sources (after preprocessing both with sed) with wdiff. Second, converting both versions to plain text using pandoc, and comparing the result (again with wdiff). Third, for GLEPs 63 to 73 which were initiated in the Wiki, I have compared the visual appearance of the rendering by rst2html.py with that of the Wiki version.

In my opinion the RSTs versions are a faithful reproduction of the Wiki versions.


(In reply to Michał Górny from comment #3)

> Vote: "The Council approves the attached GLEP conversion as valid and
> accurate".

I vote yes.
Comment 5 Kristian Fiskerstrand (RETIRED) gentoo-dev 2017-10-08 17:07:43 UTC
(In reply to Michał Górny from comment #3)
> Vote: "The Council approves the attached GLEP conversion as valid and
> accurate".


I vote yes
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2017-10-08 18:23:31 UTC
> Vote: "The Council approves the attached GLEP conversion as valid and
> accurate".


I vote yes
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2017-10-08 20:31:07 UTC
Approved by unanimous vote during today's council meeting.
Log & summary to be posted.