make[1]: Entering directory '/var/tmp/portage/sys-auth/google-authenticator-1.01_pre20160307231538/work/google-authenticator-1.01' make[2]: Entering directory '/var/tmp/portage/sys-auth/google-authenticator-1.01_pre20160307231538/work/google-authenticator-1.01' FAIL: pam_google_authenticator_unittest ============================================================================ Testsuite summary for google-authenticator 1.01 ============================================================================ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.0_20170706-204158 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-6.3.0 * Available Python interpreters, in order of preference: [1] python3.4 [2] python3.5 (fallback) [3] python2.7 (fallback) Available Ruby profiles: [1] ruby21 (with Rubygems) [2] ruby22 (with Rubygems) * java-config: The following VMs are available for generation-2:
Created attachment 483224 [details] emerge-info.txt
Created attachment 483226 [details] emerge-history.txt
Created attachment 483228 [details] environment
Created attachment 483230 [details] etc.portage.tbz2
Created attachment 483232 [details] logs.tbz2
Created attachment 483234 [details] sys-auth:google-authenticator-1.01_pre20160307231538:20170711-093355.log
Created attachment 483236 [details] temp.tbz2
Reported upstream at https://github.com/google/google-authenticator-libpam/issues/68
The upstream issue is closed. 1.05 has RESTRICT="test". If I remove that, the test fails. However, if I compile manually, the test succeeds. The failed test outputs the same error as in the mentioned upstream issue, but gives an additional hint: »Failed to change user id to "nobody"«. With FEATURES="-userpriv" the test fails with »pam_google_authenticator_unittest: tests/pam_google_authenticator_unittest.c:382: main: Assertion `pam _sm_authenticate(NULL, 0, targc, targv) == PAM_IGNORE' failed.« instead. Looks like it fails due to sandboxing. Can we close this?
Could we remove RESTRICT=test and patch the source to just disable the failing test, allowing the others to run?
(In reply to Craig Andrews from comment #10) > Could we remove RESTRICT=test and patch the source to just disable the > failing test, allowing the others to run? Yes please, many packages do this.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa7da5ea0d4cf2d11be41b82ac64f80b2dfa9294 commit aa7da5ea0d4cf2d11be41b82ac64f80b2dfa9294 Author: Ronny Gutbrod <gentoo@tastytea.de> AuthorDate: 2020-04-11 19:24:44 +0000 Commit: Craig Andrews <candrews@gentoo.org> CommitDate: 2020-04-11 19:58:51 +0000 sys-auth/google-authenticator: Remove failing tests. Closes: https://bugs.gentoo.org/624588 Signed-off-by: Ronny Gutbrod <gentoo@tastytea.de> Closes: https://github.com/gentoo/gentoo/pull/15312 Signed-off-by: Craig Andrews <candrews@gentoo.org> .../files/1.08-remove-failing-tests.patch | 301 +++++++++++++++++++++ .../google-authenticator-1.08.ebuild | 2 +- .../google-authenticator-9999.ebuild | 2 +- 3 files changed, 303 insertions(+), 2 deletions(-)
