Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624044 - dev-perl/Term-ReadLine-TTYtter-1.4: fails with FEATURES=test
Summary: dev-perl/Term-ReadLine-TTYtter-1.4: fails with FEATURES=test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Peter Gantner (a.k.a. nephros)
URL:
Whiteboard: cleanup old after 2018-03-10
Keywords: TESTFAILURE
: 623132 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-07-06 18:06 UTC by Toralf Förster
Modified: 2018-03-13 12:05 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Term-ReadLine-TTYtter-1.4.ebuild, set AUTOMATED_TESTING variable to skip tests (Term-ReadLine-TTYtter-1.4.ebuild,457 bytes, text/plain)
2017-10-11 14:51 UTC, Peter Gantner (a.k.a. nephros)
Details
Term-ReadLine-TTYtter-1.4.ebuild (Term-ReadLine-TTYtter-1.4.ebuild,449 bytes, text/plain)
2017-10-11 14:56 UTC, Peter Gantner (a.k.a. nephros)
Details
Term-ReadLine-TTYtter-1.4-nointeractive.patch (0001-Use-file-for-input-data-instead-of-STDIN-non-interac.patch,2.13 KB, patch)
2018-02-27 21:03 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff
Term-ReadLine-TTYtter-1.4-nointeractive.patch (0001-Use-file-for-input-data-instead-of-STDIN-non-interac.patch,2.38 KB, patch)
2018-02-27 21:06 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-07-06 18:06:48 UTC
emerge hang - I killed it
Comment 1 Jonas Stein gentoo-dev 2017-07-06 19:29:06 UTC
Thank you for your bug reports. Tickets will be assigned even faster, if you assign your own tickets directly as author. 
We prepared a JavaScript plugin [1] for greasemonkey [2] which makes this very fast and easy.
[1] https://github.com/mgorny/bug-assign-user-js
[2] https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/
Comment 2 Peter Gantner (a.k.a. nephros) 2017-10-11 14:46:17 UTC
FEATURES=test causes "make test" to execute the shipped test.pl, which is interactive (expects input), so emerge hangs.

The script however doesn't do a lot, it simply allows a tester to evaluate perl expressions manually.

Two possible solutions:

 1. set RESTRICT="test" for that ebuild so tests are skipped by emerge
 2. setting the "AUTOMATED_TESTING=1" env variable so tests are skipped by test.pl
Comment 3 Peter Gantner (a.k.a. nephros) 2017-10-11 14:51:10 UTC
Created attachment 498394 [details]
Term-ReadLine-TTYtter-1.4.ebuild, set AUTOMATED_TESTING variable to skip tests
Comment 4 Peter Gantner (a.k.a. nephros) 2017-10-11 14:56:34 UTC
Created attachment 498396 [details]
Term-ReadLine-TTYtter-1.4.ebuild

same thing, don't need the 'export' actually
Comment 5 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2018-02-27 20:13:44 UTC
*** Bug 623132 has been marked as a duplicate of this bug. ***
Comment 6 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2018-02-27 20:22:40 UTC
Sorry for the delay: Perl team would prefer it if there was some mechanism to coerce tests to be run in some regard, no matter how insignificant they may be.

Hacks that simply *disable* tests aren't very useful.

This is especially important given that without executing tests, there's no way to determine if a Perl module even has valid syntax, unlike C applications which at least have a safety net of a compile stage.

I'm looking into this atm, and it seems there might be a way to redirect test input into the tests STDIN, which might make this work.

At least then the test feature set, however arbitrarily simple, might provide some sort of useful coverage.

NB: May require patching the tests to get some kind of useful reaction.
Comment 7 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2018-02-27 21:03:54 UTC
Created attachment 521340 [details, diff]
Term-ReadLine-TTYtter-1.4-nointeractive.patch

Attached is the patch I'd apply, which makes the test do *something* useful, and possibly trigger TTYtter codepaths.

If the primary maintainer has no oppositions, I'll add it in an -r1 bump within the next 7 days. ( -r1 bump mostly for EAPI6ification ), and then purge the affected EAPI5 version 7 days after that.
Comment 8 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2018-02-27 21:06:22 UTC
Created attachment 521342 [details, diff]
Term-ReadLine-TTYtter-1.4-nointeractive.patch

Patch fixed to include input file.
Comment 9 Peter Gantner (a.k.a. nephros) 2018-03-01 12:08:43 UTC
Fine by me. Thanks.
Comment 10 Larry the Git Cow gentoo-dev 2018-03-03 02:41:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=643430df185f46339d7eaa13933eb11fff76f57d

commit 643430df185f46339d7eaa13933eb11fff76f57d
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2018-03-03 02:40:04 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2018-03-03 02:40:52 +0000

    dev-perl/Term-ReadLine-TTYtter: Fix interactive tests bug #624044
    
    - EAPI6
    - Tidy metadata.xml
    - Add upstream remote-id's
    - Patch out interactive tests while retaining some exectuable
      functionality testing
    - Normalize version
    
    Bug: https://bugs.gentoo.org/624044
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

 .../Term-ReadLine-TTYtter-1.400.0-r1.ebuild        | 18 +++++
 .../Term-ReadLine-TTYtter-1.4-nointeractive.patch  | 78 ++++++++++++++++++++++
 dev-perl/Term-ReadLine-TTYtter/metadata.xml        | 32 +++++----
 3 files changed, 116 insertions(+), 12 deletions(-)}
Comment 11 Larry the Git Cow gentoo-dev 2018-03-13 12:05:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f85dc0f20b89db0d0fef8273074662a564505f6d

commit f85dc0f20b89db0d0fef8273074662a564505f6d
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2018-03-13 12:05:33 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2018-03-13 12:05:48 +0000

    dev-perl/Term-ReadLine-TTYtter: Cleanup old re bug #624044
    
    Closes: https://bugs.gentoo.org/624044
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 .../Term-ReadLine-TTYtter-1.4.ebuild                  | 19 -------------------
 1 file changed, 19 deletions(-)