Bug 623650 – net-p2p/deluge-1.3.15 fails to show Preferences window; bug fixed upstream

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description wyvern5 2017-07-03 15:56:18 UTC]

The linked URL shows someone complaining of this problem and an upstream commit fixing the issue. 

Manually applying that diff to /usr/lib/python2.7/site-packages/deluge/ui/gtkui/preferences.py fixes the problem.

Reproducible: Always

Steps to Reproduce:
1. Start deluge: `deluge-gtk`
2. Click Preferences
3. Observe error printed:
Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/twisted/protocols/policies.py", line 120, in dataReceived
    self.wrappedProtocol.dataReceived(data)
  File "/usr/lib64/python2.7/site-packages/deluge/ui/client.py", line 179, in dataReceived
    d.callback(request[2])
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 382, in callback
    self._startRunCallbacks(result)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/deluge/ui/gtkui/preferences.py", line 221, in _on_get_cache_status
    self._show()
  File "/usr/lib64/python2.7/site-packages/deluge/ui/gtkui/preferences.py", line 323, in _show
    lt_single_proxy = component.get("PreferencesManager").LT_SINGLE_PROXY
  File "/usr/lib64/python2.7/site-packages/deluge/component.py", line 427, in get
    return _ComponentRegistry.components[name]
exceptions.KeyError: 'PreferencesManager'
Actual Results:  
Prints error.

Expected Results:  
Should show preferences window.

[Comment 1 Paolo Pedroni 2017-07-12 09:47:59 UTC]

Created attachment 483340 [details, diff]
deluge-1.3.15-r1-fix-preferences-ui.patch

[Comment 2 Paolo Pedroni 2017-07-12 09:50:48 UTC]

Created attachment 483342 [details, diff]
deluge-1.3.15-r1.ebuild.patch

This patch upgrades the ebuild to apply previous patch. Not straight to stable, of course, unless proxy-mantainer says so.

[Comment 3 Kristian Fiskerstrand (RETIRED) 2017-07-28 14:47:23 UTC]

(In reply to Paolo Pedroni from comment #2)
> Created attachment 483342 [details, diff] [details, diff]
> deluge-1.3.15-r1.ebuild.patch
> 
> This patch upgrades the ebuild to apply previous patch. Not straight to
> stable, of course, unless proxy-mantainer says so.

Can you provide this as a git format-patch that does the revision bump and includes a proper commit message, please?

[Comment 4 Paolo Pedroni 2017-07-28 15:12:22 UTC]

I'm on holiday ATM, and I have no computer access. I'll be back after August 6th. Can you wait?

[Comment 5 Paolo Pedroni 2017-08-30 14:44:33 UTC]

Created attachment 491108 [details, diff]
0001-net-p2p-deluge-new-ebuild-with-fix-to-preferences-ui.patch

Here is the patch in the requested format. Sorry for the delay.

[Comment 6 Paolo Pedroni 2017-09-11 07:55:04 UTC]

Please, Kristian (or anyone else in proxy-maint@g.o), can you apply this?

[Comment 7 Larry the Git Cow 2017-10-16 20:38:40 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9180e836c5fbd22c5aecde178597faa0bcaaf30e

commit 9180e836c5fbd22c5aecde178597faa0bcaaf30e
Author:     PPed72 <[e-mail]>
AuthorDate: 2017-08-30 14:38:06 +0000
Commit:     Kristian Fiskerstrand <[e-mail]>
CommitDate: 2017-10-16 20:36:45 +0000

    net-p2p/deluge: fix to preferences ui
    
    Bug: https://bugs.gentoo.org/623650

 net-p2p/deluge/deluge-1.3.15-r1.ebuild             | 144 +++++++++++++++++++++
 .../deluge-1.3.15-r1-fix-preferences-ui.patch      |  32 +++++
 2 files changed, 176 insertions(+)}