Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 623602 - games-util/qjoypad-4.3.0 version bump and switch to qt5
Summary: games-util/qjoypad-4.3.0 version bump and switch to qt5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: qt4-removal
  Show dependency tree
 
Reported: 2017-07-02 22:41 UTC by maurerpe
Modified: 2017-12-21 10:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qjoypad-4.3.0.ebuild (qjoypad-4.3.0.ebuild,719 bytes, text/plain)
2017-07-02 22:41 UTC, maurerpe
Details
Updated Ebuild (qjoypad-4.3.0.ebuild,707 bytes, text/plain)
2017-07-04 19:26 UTC, maurerpe
Details
qjoypad-4.3.0.ebuild (qjoypad-4.3.0.ebuild,707 bytes, text/plain)
2017-07-04 19:30 UTC, maurerpe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description maurerpe 2017-07-02 22:41:27 UTC
Created attachment 480078 [details]
qjoypad-4.3.0.ebuild

There is a qt5 port of qjoypad available from github:
https://github.com/panzi/qjoypad/releases

ebuild attached.
Comment 1 Jonas Stein gentoo-dev 2017-07-03 16:24:50 UTC
Thank you for your contribution. I had a short look on the ebuild:

Here are a few suggestions.

please test the ebuild with repoman

There should be no
# $Id$

I suggest to bump to 
EAPI=6

Use the variables here:
SRC_URI="https://github.com/panzi/qjoypad/archive/v4.3.0.tar.gz"

https://devmanual.gentoo.org/ebuild-writing/variables/


KEYWORDS="amd64 ppc x86"
need "~" 

Try to avoid the for loop over *. It is likely it fails some day.
Comment 2 maurerpe 2017-07-04 19:26:11 UTC
Created attachment 480772 [details]
Updated Ebuild

Thank you, Jonas, for the suggestions.  I have attached an updated ebuild based on your comments.  Repoman is happy with this one.  Please take a look and make sure I did everything correctly.
Comment 3 maurerpe 2017-07-04 19:30:51 UTC
Created attachment 480776 [details]
qjoypad-4.3.0.ebuild

Updated copyright year to 2017.
Comment 4 Jonas Stein gentoo-dev 2017-07-04 20:03:40 UTC
You are welcome. The ebuild is much better now.
The bug tracker is not suited well for discussions, but I invite you to discuss it on the IRC channel #gentoo or #gentoo-dev-help.
In the meantime you can compile your ebuild and look with ldd in your executable and check, if all linked libs are the dependency list.
Comment 5 maurerpe 2017-07-09 05:21:05 UTC
$ ldd /usr/bin/qjoypad
	linux-vdso.so.1 (0x00007ffc20b55000)
	libQt5Widgets.so.5 => /usr/lib64/libQt5Widgets.so.5 (0x00007f60808c5000)
	libQt5X11Extras.so.5 => /usr/lib64/libQt5X11Extras.so.5 (0x00007f6081100000)
	libXtst.so.6 => /usr/lib64/libXtst.so.6 (0x00007f60806bf000)
	libX11.so.6 => /usr/lib64/libX11.so.6 (0x00007f6080381000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f60810dc000)
	libQt5Gui.so.5 => /usr/lib64/libQt5Gui.so.5 (0x00007f607fee7000)
	libQt5Core.so.5 => /usr/lib64/libQt5Core.so.5 (0x00007f607fa68000)
	libstdc++.so.6 => /usr/lib/gcc/x86_64-pc-linux-gnu/6.3.0/libstdc++.so.6 (0x00007f607f666000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f607f36c000)
	libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/6.3.0/libgcc_s.so.1 (0x00007f607f155000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f607edbc000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f607eba0000)
	libXext.so.6 => /usr/lib64/libXext.so.6 (0x00007f607e98e000)
	libxcb.so.1 => /usr/lib64/libxcb.so.1 (0x00007f607e764000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f607e560000)
	librt.so.1 => /lib64/librt.so.1 (0x00007f607e358000)
	libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f607e141000)
	libcap.so.2 => /lib64/libcap.so.2 (0x00007f607df3b000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f6080f29000)
	libharfbuzz.so.0 => /usr/lib64/libharfbuzz.so.0 (0x00007f607dca7000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f607da90000)
	libGL.so.1 => /usr/lib64/libGL.so.1 (0x00007f607d81d000)
	libpng16.so.16 => /usr/lib64/libpng16.so.16 (0x00007f607d5e7000)
	libicui18n.so.58 => /usr/lib64/libicui18n.so.58 (0x00007f607d171000)
	libicuuc.so.58 => /usr/lib64/libicuuc.so.58 (0x00007f607cdc7000)
	libpcre16.so.0 => /usr/lib64/libpcre16.so.0 (0x00007f607cb5e000)
	libdouble-conversion.so.1 => /usr/lib64/libdouble-conversion.so.1 (0x00007f607c94d000)
	libglib-2.0.so.0 => /usr/lib64/libglib-2.0.so.0 (0x00007f607c639000)
	libXau.so.6 => /usr/lib64/libXau.so.6 (0x00007f607c435000)
	libXdmcp.so.6 => /usr/lib64/libXdmcp.so.6 (0x00007f607c22f000)
	libattr.so.1 => /lib64/libattr.so.1 (0x00007f607c02a000)
	libfreetype.so.6 => /usr/lib64/libfreetype.so.6 (0x00007f607bd74000)
	libgraphite2.so.3 => /usr/lib64/libgraphite2.so.3 (0x00007f607bb47000)
	libexpat.so.1 => /usr/lib64/libexpat.so.1 (0x00007f607b91c000)
	libxcb-dri3.so.0 => /usr/lib64/libxcb-dri3.so.0 (0x00007f607b719000)
	libxcb-xfixes.so.0 => /usr/lib64/libxcb-xfixes.so.0 (0x00007f607b511000)
	libxcb-present.so.0 => /usr/lib64/libxcb-present.so.0 (0x00007f607b30e000)
	libxcb-sync.so.1 => /usr/lib64/libxcb-sync.so.1 (0x00007f607b107000)
	libxshmfence.so.1 => /usr/lib64/libxshmfence.so.1 (0x00007f607af05000)
	libglapi.so.0 => /usr/lib64/libglapi.so.0 (0x00007f607acd5000)
	libXdamage.so.1 => /usr/lib64/libXdamage.so.1 (0x00007f607aad2000)
	libXfixes.so.3 => /usr/lib64/libXfixes.so.3 (0x00007f607a8cc000)
	libX11-xcb.so.1 => /usr/lib64/libX11-xcb.so.1 (0x00007f607a6ca000)
	libxcb-glx.so.0 => /usr/lib64/libxcb-glx.so.0 (0x00007f607a4ad000)
	libxcb-dri2.so.0 => /usr/lib64/libxcb-dri2.so.0 (0x00007f607a2a8000)
	libXxf86vm.so.1 => /usr/lib64/libXxf86vm.so.1 (0x00007f607a0a2000)
	libdrm.so.2 => /usr/lib64/libdrm.so.2 (0x00007f6079e91000)
	libicudata.so.58 => /usr/lib64/libicudata.so.58 (0x00007f607838f000)
	libpcre.so.1 => /lib64/libpcre.so.1 (0x00007f607811c000)
	libbsd.so.0 => /usr/lib64/libbsd.so.0 (0x00007f6077f07000)
	libbz2.so.1 => /lib64/libbz2.so.1 (0x00007f6077cf6000)

To determine which packages these were associated with, I then ran:
$ (for name in `ldd /usr/bin/qjoypad | grep '=>' | sed -e 's/^.*=> \([^(]*\).*$/\1/'`; do equery belongs $name; done) | sort | uniq
app-arch/bzip2-1.0.6-r8
dev-libs/double-conversion-2.0.1
dev-libs/expat-2.2.1
dev-libs/glib-2.50.3-r1
dev-libs/icu-58.2-r1
dev-libs/libbsd-0.8.3
dev-libs/libpcre-8.40-r1
dev-qt/qtcore-5.7.1-r3
dev-qt/qtgui-5.7.1-r1
dev-qt/qtwidgets-5.7.1
dev-qt/qtx11extras-5.7.1
media-gfx/graphite2-1.3.10
media-libs/freetype-2.8
media-libs/harfbuzz-1.4.5
media-libs/libpng-1.6.30
media-libs/mesa-17.1.4
sys-apps/attr-2.4.47-r2
sys-devel/gcc-6.3.0
sys-fs/udev-225-r1
sys-libs/glibc-2.23-r4
sys-libs/libcap-2.24-r2
sys-libs/zlib-1.2.11
x11-libs/libdrm-2.4.81
x11-libs/libX11-1.6.5
x11-libs/libXau-1.0.8
x11-libs/libxcb-1.12-r2
x11-libs/libXdamage-1.1.4-r1
x11-libs/libXdmcp-1.1.2-r1
x11-libs/libXext-1.3.3
x11-libs/libXfixes-5.0.3
x11-libs/libxshmfence-1.2
x11-libs/libXtst-1.2.3
x11-libs/libXxf86vm-1.1.4

How do I know which of these need to be on the dependency list?
Comment 6 Larry the Git Cow gentoo-dev 2017-12-21 09:58:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9da90fe7061b7eef0656967d15bc151e54bd078b

commit 9da90fe7061b7eef0656967d15bc151e54bd078b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-12-21 09:54:29 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-12-21 09:58:28 +0000

    games-util/qjoypad: Drop old
    
    Closes: https://bugs.gentoo.org/623602
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 games-util/qjoypad/Manifest                        |  1 -
 .../qjoypad/files/qjoypad-4.1.0-underlink.patch    | 11 -----
 games-util/qjoypad/qjoypad-4.1.0.ebuild            | 50 ----------------------
 3 files changed, 62 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec69b2fc143f28426a3db59160b157f5cc2c2b5f

commit ec69b2fc143f28426a3db59160b157f5cc2c2b5f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-12-21 09:49:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-12-21 09:58:28 +0000

    games-util/qjoypad: 4.3.0 version bump
    
    Bug: https://bugs.gentoo.org/623602
    Thanks-to: maurerpe <junk4me46806@yahoo.com>
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 games-util/qjoypad/Manifest             |  1 +
 games-util/qjoypad/qjoypad-4.3.0.ebuild | 42 +++++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)}
Comment 7 Andreas Sturmlechner gentoo-dev 2017-12-21 10:01:07 UTC
(In reply to maurerpe from comment #5)
> How do I know which of these need to be on the dependency list?

Thanks for your work! I've used lddtree to add some more required dependencies to the list, and dropped the invalid ~ppc keyword.