Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 618410 - media-libs/libopenshot-audio-0.1.4 version bump
Summary: media-libs/libopenshot-audio-0.1.4 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Louis Sautier (sbraz)
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-14 05:58 UTC by Vladimir
Modified: 2017-07-26 12:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libopenshot-audio-0.1.4.ebuild (libopenshot-audio-0.1.4.ebuild,768 bytes, text/plain)
2017-05-14 05:58 UTC, Vladimir
Details
libopenshot-audio-0.1.4-r1.ebuild (libopenshot-audio-0.1.4.ebuild,785 bytes, text/plain)
2017-07-23 20:30 UTC, maurerpe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir 2017-05-14 05:58:14 UTC
Created attachment 472540 [details]
libopenshot-audio-0.1.4.ebuild

Newer version with the ebuild renamed from the older one.
Comment 1 maurerpe 2017-07-23 20:30:31 UTC
Created attachment 486658 [details]
libopenshot-audio-0.1.4-r1.ebuild

I added a missing dependency:
  x11-libs/libICE
I can confirm that this ebuild works.
Comment 2 Louis Sautier (sbraz) gentoo-dev 2017-07-23 20:38:24 UTC
Are you sure libICE is directly required by libopenshot-audio? Isn't it an indirect dependency? I don't see any references to libICE in the source.
As for the bump, I made a PR here https://github.com/gentoo/gentoo/pull/4902
But I had to block it because I upgraded to ImageMagick 7 which breaks libopenshot. This will have to be fixed upstream as I can't easily downgrade my ImageMagick.
Comment 3 maurerpe 2017-07-24 00:17:59 UTC
You are right.  It does NOT directly depend on libICE. It won't work without it, the configure script explicitly checks for it, and it links with -lICE, but it doesn't use it directly.

It seems I was fooled by cmake.  When I saw it show up in the configure script output, I thought it was a direct dependency.  I said, "Why bother to check for something that you aren't using?"  But, apparently cmake doesn't work that way.  The check for ICE actually happens in FindX11.cmake which is installed by cmake itself.
Comment 4 Louis Sautier (sbraz) gentoo-dev 2017-07-26 12:56:24 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/media-libs/libopenshot-audio?id=e082ba72e7e105aedbe895a9c93770fdf6d1d667
media-libs/libopenshot-audio: bump to 0.1.4, #618410