Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616358 - dev-libs/glib-2.50.3: pax-mark -mr "${BUILD_DIR}"/tests/.libs/assert-msg-test is a no-op
Summary: dev-libs/glib-2.50.3: pax-mark -mr "${BUILD_DIR}"/tests/.libs/assert-msg-test...
Status: RESOLVED DUPLICATE of bug 676440
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-23 05:53 UTC by mikey
Modified: 2019-07-26 05:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mikey 2017-04-23 05:53:59 UTC
The lines

    # Hardened: gdb needs this, bug #338891
    if host-is-pax ; then
        pax-mark -mr "${BUILD_DIR}"/tests/.libs/assert-msg-test \
                || die "Hardened adjustment failed" 
    fi

are a no-op since at time of execution the file "${BUILD_DIR}"/tests/.libs/assert-msg-test is not yet build (it is build in emake check).
(Another question is whether it is intended behaviour for pax-mark to not fail if the file does not exist.)

I suggest to remove this piece of code (and maybe also inherit pax-utils but I have not checked if it is used elsewhere) which gives the false impression that bug with gdb and PAX is fixed/handled properly.

An approach to marking the (to be build) executable assert-msg-test is to call paxmark.sh in glib-2.50.3/tests/run-assert-msg-test.sh, e.g. add

    paxmark.sh -mr ./assert-msg-test

to that file as indirectly suggested by Antonio Basile in bug #504020 comment 5 [0].

[0] https://bugs.gentoo.org/show_bug.cgi?id=504020#c5
Comment 1 mikey 2017-04-23 05:56:36 UTC
(In reply to mikey from comment #0)
> The lines
> 
>     # Hardened: gdb needs this, bug #338891
>     if host-is-pax ; then
>         pax-mark -mr "${BUILD_DIR}"/tests/.libs/assert-msg-test \
>                 || die "Hardened adjustment failed" 
>     fi

To clarify these lines are located in multilib_src_test().
Comment 2 Mart Raudsepp gentoo-dev 2019-07-26 05:20:35 UTC
I've removed pax marking from 2.60.6, though with meson they would be built at this point (but at a different location than ../.libs/..

*** This bug has been marked as a duplicate of bug 676440 ***