Bug 614768 – dev-libs/libgit2 fails to build against openssl-1.1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Lars Wendler (Polynomial-C) (RETIRED) 2017-04-05 15:17:56 UTC]

Created attachment 469244 [details]
build.log

/usr/bin/x86_64-pc-linux-gnu-gcc -DGIT_ARCH_64 -DGIT_CURL -DGIT_OPENSSL -DGIT_THREADS -DGIT_USE_NSEC -DGIT_USE_STAT_MTIM -DHAVE_FUTIMENS -DHAVE_QSORT_R -DOPENSSL_SHA1 -D_FILE_OFFSET_BITS=64 -Dgit2_EXPORTS -I/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src -I/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/include   -DNDEBUG -D_GNU_SOURCE -Wall -Wextra -march=native -mtune=native -O2 -pipe -fvisibility=hidden -fPIC -Wno-missing-field-initializers -Wstrict-aliasing=2 -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-function -fPIC   -o CMakeFiles/git2.dir/src/openssl_stream.c.o -c /var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c: In function ‘openssl_locking_function’:
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c:52:16: error: ‘CRYPTO_LOCK’ undeclared (first use in this function)
  lock = mode & CRYPTO_LOCK;
                ^
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c:52:16: note: each undeclared identifier is reported only once for each function it appears in
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c: In function ‘shutdown_ssl_locking’:
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c:65:14: warning: implicit declaration of function ‘CRYPTO_num_locks’ [-Wimplicit-function-declaration]
  num_locks = CRYPTO_num_locks();
              ^
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c:66:2: warning: implicit declaration of function ‘CRYPTO_set_locking_callback’ [-Wimplicit-function-declaration]
  CRYPTO_set_locking_callback(NULL);
  ^
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c: In function ‘git_openssl_stream_global_init’:
/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1/src/openssl_stream.c:106:2: warning: implicit declaration of function ‘SSL_load_error_strings’ [-Wimplicit-function-declaration]
  SSL_load_error_strings();
  ^
make[2]: *** [CMakeFiles/git2.dir/build.make:1623: CMakeFiles/git2.dir/src/openssl_stream.c.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1_build'
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/git2.dir/all] Error 2
make[1]: Leaving directory '/var/tmp/portage/dev-libs/libgit2-0.25.1/work/libgit2-0.25.1_build'
make: *** [Makefile:130: all] Error 2


Please note that installed openssl-1.1 has been compiled with all deprecated
features being removed (--api=1.1.0)!

[Comment 1 Manuel Rüger (RETIRED) 2017-04-12 01:07:00 UTC]

Seems this was fixed https://github.com/libgit2/libgit2/pull/4195 and will be in a future release. Do you want me to patch it into the current one or is waiting okay?

[Comment 2 Lars Wendler (Polynomial-C) (RETIRED) 2017-04-12 07:26:08 UTC]

I'm completely fine with waiting. 
We have so many unfixed openssl-1.1 bugs that there is no real pressure to get this one fixed ASAP.

[Comment 3 Manuel Rüger (RETIRED) 2017-07-02 20:17:33 UTC]

v0.26
Changes or improvements

    We can now build against OpenSSL v1.1 and against LibreSSL.

[Comment 4 Lars Wendler (Polynomial-C) (RETIRED) 2019-04-21 01:20:50 UTC]

Should be fixed...