612846 – sys-apps/portage: flawed logic involving depgraph atom_not_selected variable prevents slot operator rebuilds from being triggered

Bug 612846 - sys-apps/portage: flawed logic involving depgraph atom_not_selected variable prevents slot operator rebuilds from being triggered

Summary: sys-apps/portage: flawed logic involving depgraph atom_not_selected variable ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core - Interface (emerge) (show other bugs)
Hardware:	All All

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	300071 611742 612780
	Show dependency tree

Reported:	2017-03-16 20:25 UTC by Zac Medico
Modified:	2017-05-20 18:26 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Zac Medico gentoo-dev

2017-03-16 20:25:19 UTC

In the depgraph _slot_operator_update_probe method, initialization of the atom_not_selected variable can be accidentally skipped in some cases, which makes the method fail to properly identify slot operator rebuild candidates. I'll post a patch that solves the problem.

Comment 1 Zac Medico gentoo-dev

2017-03-16 21:22:37 UTC

Patch send for review:

https://archives.gentoo.org/gentoo-portage-dev/message/8f8b6d1803aa48fab74e6d17b6a7015e
https://github.com/gentoo/portage/pull/141

Comment 2 Zac Medico gentoo-dev

2017-03-16 23:28:30 UTC

This is in the master branch:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=e5d638cf855656afab141da8d7b4d7f66cad3450

Comment 3 Zac Medico gentoo-dev

2017-05-20 18:26:30 UTC

Fixed in portage-2.3.5.