Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612112 - dev-python/netcdf4-python-1.5.3 version bump
Summary: dev-python/netcdf4-python-1.5.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL: https://github.com/Unidata/netcdf4-py...
Whiteboard:
Keywords: EBUILD, PullRequest
: 681746 (view as bug list)
Depends on: 681744
Blocks:
  Show dependency tree
 
Reported: 2017-03-09 11:39 UTC by Erik Quaeghebeur
Modified: 2020-12-28 16:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (netcdf4-python-1.3.1.ebuild,709 bytes, text/plain)
2018-02-28 20:31 UTC, Erik Quaeghebeur
Details
netcdf4-python-1.5.0.ebuild (updated) (netcdf4-python-1.5.0.ebuild,942 bytes, text/plain)
2019-03-25 21:11 UTC, Juan Hernandez-Diaz
Details
netcdf4-python-1.5.0.ebuild (updated) (netcdf4-python-1.5.0.ebuild,921 bytes, text/plain)
2019-03-25 22:23 UTC, Juan Hernandez-Diaz
Details
updated ebuild (netcdf4-python-1.5.3.ebuild,972 bytes, text/plain)
2020-05-22 12:15 UTC, Erik Quaeghebeur
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Erik Quaeghebeur 2017-08-30 07:59:42 UTC
Please update, many bugfixes have been applied since 1.2.2 <https://github.com/Unidata/netcdf4-python/blob/master/Changelog>. Thanks
Comment 2 Erik Quaeghebeur 2018-02-28 20:31:26 UTC
Created attachment 521480 [details]
updated ebuild

Based on the changelog and on the contents of setup.py for this package, I've created an updated ebuild. There is now support for mpi, which I have put behind an ‘mpi’ use flag. Also some minimal versions have changed.

I have not tested the mpi functionality, as I have absolutely no experience with that. However, I have tested the version without it and it works nicely.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-25 17:36:32 UTC
*** Bug 681746 has been marked as a duplicate of this bug. ***
Comment 4 Juan Hernandez-Diaz 2019-03-25 21:11:54 UTC
Created attachment 570816 [details]
netcdf4-python-1.5.0.ebuild (updated)

According to the changelog and the installation procedure presented at http://unidata.github.io/netcdf4-python/netCDF4/index.html, an ebuild is included that includes USE dap, hdf and mpi (all verified). 

Additionally, the dependency to the cftime package is included (https://bugs.gentoo.org/681744)
Comment 5 Erik Quaeghebeur 2019-03-25 21:57:12 UTC
(In reply to Juan Camilo Hernandez from comment #4)
> Created attachment 570816 [details]
> netcdf4-python-1.5.0.ebuild (updated)
That looks very nice.

Minor comments:
* shouldn't cython be in DEPEND instead of RDEPEND?
* https://unidata.github.io/netcdf4-python seems less fragile than https://unidata.github.io/netcdf4-python/netCDF4/index.html
* is python3_{4,5,6} or python{3_5,3_6,3_7} preferred?
* is "OSI Approved" or "MIT" (more specific) preferred?
* should the keywords be expanded to "~amd64 ~x86 ~amd64-linux ~x86-linux" as in the old ebuild?
Comment 6 Juan Hernandez-Diaz 2019-03-25 22:23:28 UTC
Created attachment 570824 [details]
netcdf4-python-1.5.0.ebuild (updated)

(In reply to Erik Quaeghebeur from comment #5)

Thank you very much for your comments, I have put into practice several of them.

For the KEYWORDS variable, I have been conservative. I limited myself to indicate the hadrware where I could test my ebuild.
Comment 7 Erik Quaeghebeur 2019-07-16 08:37:53 UTC
1.5.1.2 is available:

https://github.com/Unidata/netcdf4-python/releases/tag/v1.5.1.2rel

I tested the old ebuild and it still works. The minimal required numpy needs to be changed to 1.10, however. See https://github.com/Unidata/netcdf4-python/blob/v1.5.1.2rel/Changelog line 10.
Comment 8 Erik Quaeghebeur 2020-05-22 12:15:27 UTC
Created attachment 640884 [details]
updated ebuild

I've added an updated ebuild for version 1.5.3. It installs and works fine here.
Comment 9 Erik Quaeghebeur 2020-05-22 12:16:50 UTC
Forgot to mention: I removed Python 2.7 support, because that is deprecated. Also, it held up the numpy upgrade after the numpy vs. numpy-python2 split.
Comment 10 Larry the Git Cow gentoo-dev 2020-12-28 16:10:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=854e2a7b29c6053477dd63bc76d61d2db2c06858

commit 854e2a7b29c6053477dd63bc76d61d2db2c06858
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-12-28 16:10:49 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-12-28 16:10:49 +0000

    dev-python/netcdf4-python: Bump to 1.5.5
    
    Closes: https://github.com/gentoo/gentoo/pull/18735
    Closes: https://bugs.gentoo.org/612112
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-python/netcdf4-python/Manifest                 |  1 +
 .../files/netcdf4-python-1.5.5-tests.patch         | 33 +++++++++++++++++
 dev-python/netcdf4-python/metadata.xml             | 28 +++++++--------
 .../netcdf4-python/netcdf4-python-1.5.5.ebuild     | 41 ++++++++++++++++++++++
 4 files changed, 89 insertions(+), 14 deletions(-)