Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 607474 - >=media-sound/abcde-2.7: media-sound/dagrab is an alternative to cdparanoia
Summary: >=media-sound/abcde-2.7: media-sound/dagrab is an alternative to cdparanoia
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-01-28 12:59 UTC by Teika kazura
Modified: 2019-06-04 22:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
abcde-2.7.2-r1.ebuild (abcde-2.7.2-r1.ebuild,1.89 KB, text/plain)
2017-01-28 12:59 UTC, Teika kazura
Details
patch to be under ${FILESDIR} (dagrab-opts.patch,1.56 KB, patch)
2017-01-28 13:00 UTC, Teika kazura
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Teika kazura 2017-01-28 12:59:11 UTC
Created attachment 461704 [details]
abcde-2.7.2-r1.ebuild

media-sound/abcde >= 2.7 accepts media-sound/dagrab as a ripper, meaning it is an alternative to cdparanoia. (See <abcde-src>/changelog. In fact, it had been supporting dagrab, but broken, and was repaired in abcde-2.7.) But the ebuild doesn't support dagrab.

In the attached ebuild, I added a new USE flag "ripper", which requires USE="cdparanoia" or "dagrab".

I also attached a patch. In 2.7 <= abcde <= 2.8.1, the documentation on DAGRABOPTS (the option that is passed to dagrab by abcde) is lacking. The patch fixes ite. It is taken from the upstream:
 https://git.einval.com/cgi-bin/gitweb.cgi?p=abcde.git;a=commit;h=c91ca32ad9ecd236324065bfa075ce388e9c75af
(It was originally proposed at: https://abcde.einval.com/bugzilla/show_bug.cgi?id=50)
To make the patch suitable for us, I omitted the hunk for the file "changelog".

BTW abcde-2.8.1 was released on 18 Jan. It fixes an regression in 2.8.0, so there's no reason to ship 2.8.0 ebuild:
 https://abcde.einval.com/bugzilla/show_bug.cgi?id=52
 https://lists.einval.com/pipermail/abcde-users/2017-January/000229.html

For me, dagrab is far better: With cdparanoia, my pc rips only 3x, but with dagrab, it reaches about x20, with the option "-n 120". (Many users complain cdparanoia is slow, but these days dagrab is available on very few distros.)

Thanks beforehand. Regards.
Comment 1 Teika kazura 2017-01-28 13:00:42 UTC
Created attachment 461706 [details, diff]
patch to be under ${FILESDIR}
Comment 2 Teika kazura 2017-02-12 12:21:10 UTC
Alexis Ballier, excuse me for CCing to you, and thank you for bumping abcde to 2.8.1. Could you have a look at this bug?

If it is a disturbance, I'm sorry. Thank you for your effort in Gentoo.
Comment 3 Alexis Ballier gentoo-dev 2017-02-12 12:47:20 UTC
(In reply to Teika kazura from comment #2)
> If it is a disturbance, I'm sorry. Thank you for your effort in Gentoo.

I already receive sound@ emails but somehow I missed that one so that's ok :)


What I don't understand: Is abcde any useful without dev-libs/libcdio-paranoia nor media-sound/cdparanoia nor dagrab ?



We could maybe just drop the cdparanoia useflag and add a dep like:

|| ( media-sound/dagrab dev-libs/libcdio-paranoia media-sound/cdparanoia )

to avoid adding a new useflag and REQUIRED_USE

What do you think ?
Comment 4 Teika kazura 2017-02-13 01:56:15 UTC
Your guess seems right; a ripper is necessary, and the IUSE="cdparanoia" was added without much reason.[1] OTOH dagrab is quite different from cdparanoia (almost equal to libcdio-paranoia). I thought by adding IUSE="dagrab" users have more awareness of the ripper choice, but I'll respect your decision.

The reason I need dagrab is with cdparanoia it takes about 20 min. to rip a CD[3], but dagrab can do it in 4 min, as it should be. I've created a wiki page and a forum thread on dagrab.[4]

Thanks for taking care of this issue. Regards.

[1]
I had a peek into the good old gentoo-x86 repo, and commited a "manual bisect", w/o "git blame" ;-) In this commit[2], IUSE=cdparanoia was added, together with many other USE flags, following bug #174725. (A user submitted an ebuild, and it was adopted with little change.) Until that commit, no ebuild had it.

[2]
https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/media-sound/abcde?id=614307c2cb2a08f2cb2abc1239975f7fd9dc18e8

[3]
There has been sporadic complaints about slow ripping with cdparanoia, with unknown reason. Setting the speed by cdparanoia or "eject -x" doesn't work.

[4]
https://forums.gentoo.org/viewtopic-t-1059274.html
https://wiki.gentoo.org/wiki/Dagrab
Comment 5 Teika kazura 2018-04-16 11:27:08 UTC
abcde-2.9.1 was released in March.[1] As from abcde-2.9, one of the above patches is obsolete, namely the second one.

[1]
https://lists.einval.com/pipermail/abcde-users/2018-March/000277.html
See also the release note for 2.9:
https://lists.einval.com/pipermail/abcde-users/2018-March/000276.html
Comment 6 Franz Trischberger 2018-07-22 08:32:16 UTC
Any progress on this issue?
I always thought that CDs rip quite slow here. If dagrab fixes it please add support for it!

I also think the current state of abcde is somewhat broken. USE=cdparanoia is not forced, the USE-Flag is disabled. I now saw on abcde startup that it still started cdparanoia so I thought this was a bug (automagic dependency).
Introducing USE-Flags for cdparanoia-replacements should make sure that really the  requested ripper is used and not something that is present and has higher priority.
Comment 7 Larry the Git Cow gentoo-dev 2019-06-04 22:00:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=29307f23b735bc9daf89ff2675ac990e0574bd45

commit 29307f23b735bc9daf89ff2675ac990e0574bd45
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-06-04 21:28:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-06-04 21:50:59 +0000

    media-sound/abcde: Add media-sound/dagrab alternative to cdparanoia
    
    Dropping USE cdparanoia.
    
    Closes: https://bugs.gentoo.org/607474
    Package-Manager: Portage-2.3.67, Repoman-2.3.13
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/abcde/abcde-2.9.3.ebuild | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)