Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600772 - mail-filter/rspamd-*: reload doesn't work
Summary: mail-filter/rspamd-*: reload doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Roessner
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-25 08:43 UTC by Marcin Mirosław
Modified: 2019-01-16 12:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Mirosław 2016-11-25 08:43:55 UTC
start-stop-damon shouldn't have added option "--stop" when is sending HUP to rspamd.
Trivial change fixes it:
- start-stop-daemon --stop --signal HUP --quiet --pidfile $PIDFILE
+ start-stop-daemon --signal HUP --quiet --pidfile $PIDFILE



Reproducible: Always

Actual Results:  
# /etc/init.d/rspamd reload
2016-11-25 09:38:13 #21999(configtest) lua; asn.lua:169: Unknown provider_type: cymru
2016-11-25 09:38:13 #21999(configtest) <bmr7it>; symcache; rspamd_symbols_cache_post_init: cannot find dependency on symbol FILL_THIS_FORM_LONG
2016-11-25 09:38:13 #21999(configtest) <bmr7it>; symcache; rspamd_symbols_cache_post_init: cannot find dependency on symbol FREEMAIL_REPLYTO
 * Reloading rspamd ...
 * start-stop-daemon: 1 process refused to stop                    [ !! ]

Expected Results:  
# /etc/init.d/rspamd reload
2016-11-25 09:38:55 #22284(configtest) lua; asn.lua:169: Unknown provider_type: cymru
2016-11-25 09:38:55 #22284(configtest) <bmr7it>; symcache; rspamd_symbols_cache_post_init: cannot find dependency on symbol FILL_THIS_FORM_LONG
2016-11-25 09:38:55 #22284(configtest) <bmr7it>; symcache; rspamd_symbols_cache_post_init: cannot find dependency on symbol FREEMAIL_REPLYTO
 * Reloading rspamd ...                     [ ok ]
Comment 1 Christian Roessner 2018-03-22 07:50:18 UTC
Was fixed somewhere in the past
Comment 2 Marcin Mirosław 2018-03-22 08:21:54 UTC
Rather no, please look at rspamd.logrotate:
[...]
    service rspamd reopenlog >/dev/null 2>&1 || true
[...]

`service` - no such command, now service is moved out from openrc. Also
# grep reopenlog /usr/portage/mail-filter/rspamd/files/rspamd.init-r*
#

There is no function reopenlog() in init script.
Comment 3 Christian Roessner 2018-03-22 09:46:58 UTC
Hopefully this should be fixed by bug #651134
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-16 12:51:41 UTC
In rspamd-1.8.3.ebuild, runscript and logrotate was rewritten. If it wasn't fixed before, it should be fixed now.