Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 597450 - dev-lang/php: remove remaining autotools mangling
Summary: dev-lang/php: remove remaining autotools mangling
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on: 597448
Blocks:
  Show dependency tree
 
Reported: 2016-10-18 14:46 UTC by Michael Orlitzky
Modified: 2017-01-20 16:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2016-10-18 14:46:15 UTC
Our php-7.x ebuilds do only two things that require the regeneration of the autotools stuff. The first is a workaround for Heimdal support, but I've tried to fix that correctly in bug #597448. The other is to change the branding:

  # Change PHP branding
  # Get the alpha/beta/rc version
  sed -re "s|^(PHP_EXTRA_VERSION=\").*(\")|\1-pl${PR/r/}-gentoo\2|g" \
      -i configure.in || die "Unable to change PHP branding"

  # Patch PHP to show Gentoo as the server platform
  sed -e 's/PHP_UNAME=`uname -a | xargs`/PHP_UNAME=`uname -s -n -r -v | xargs`/g' \
    -i configure.in || die "Failed to fix server platform name"

Since we've modified configure.in, we need to pull in autotools.eclass, and then run eautoreconf in src_prepare().

Once the Heimdal fix is upstream, is the unique version name worth the trade-off? We're no longer doing any significant patching of PHP, so I don't see a strong reason to mess with the version string (other than that it looks cool to say "Gentoo").

Once it becomes possible, we should consider getting rid of it. The removal of the autotools eclass and eautoreconf() will speed up the build and simplify the ebuild a bit. It also gets rid of one more unnecessary deviation from upstream.
Comment 1 Michael Orlitzky gentoo-dev 2016-12-03 03:19:34 UTC
This is done in the new v7.1.0, let's see if anyone notices.
Comment 2 Michael Orlitzky gentoo-dev 2017-01-20 16:57:57 UTC
Done in 7.0.15, too. The heimdal patch isn't going to get merged into the 5.6 series, so this is out of the question there.