Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 597356 - git-r3.eclass - allow fallback from http{,s} protocol to git protocol with dev-vcs/git[-curl]
Summary: git-r3.eclass - allow fallback from http{,s} protocol to git protocol with de...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-17 12:03 UTC by Coacher
Modified: 2017-04-06 23:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2016-10-17 12:03:47 UTC
Hello.

Currently git-r3 processes URIs in the order specified in EGIT_REPO_URI.
dev-vcs/git[-curl] cannot handle http{,s} protocols, only git protocol.
git-r3 dies if it encounters http{,s} URI with dev-vcs/git[-curl] installed[1].

Some users prefer to have secure connections whenever possible, thus https URIs should be placed first in EGIT_REPO_URI to address this case.
Other users doesn't have dev-vcs/git[curl] installed, thus git URIs should be placed first in EGIT_REPO_URI to address this case.

With the current git-r3 behaviour these problems cannot be addressed simultaneously. git-r3 should allow to have http{,s} URIs placed first in EGIT_REPO_URI followed by git URIs even when user has dev-vcs/git[-curl] installed. Obviously in this case git-r3 should fallback to git protocol.

Please fix.


[1]: https://github.com/gentoo/gentoo/blob/d22cb0baccdcdf74f6fb994c4ceae95f0bbb88f5/eclass/git-r3.eclass#L589-L603
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-10-17 15:56:55 UTC
commit 24db6037e69ca7fe9c425cec72111866377adb25
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: Mon Oct 17 17:53:24 2016
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Mon Oct 17 17:56:35 2016

    git-r3.eclass: Make git[curl] warning non-fatal, extend to HTTP, #597356
    
    Make the warning about missing dev-vcs/git[curl] for HTTP(S) support
    non-fatal since the ebuild can specify non-HTTP(S) fallback URIs which
    would otherwise be ignored. The eclass will die if all URIs fail anyway.
    
    Extend the check to cover both HTTPS and plain HTTP.
    
    Reported by Coacher.
    
    Bug: https://bugs.gentoo.org/597356
Comment 2 Martin Mokrejš 2017-04-06 23:34:09 UTC
Interestingly although the ebuild referred to just git:// protocol (which is blocked on the firewall in my case now) emerge did not try https:// as the fallback. Does your fix really work?

>>> Emerging (1 of 1) sci-biology/freebayes-9999::science
>>> Unpacking source...
 * Fetching git://github.com/ekg/freebayes.git ...
git fetch git://github.com/ekg/freebayes.git +HEAD:refs/git-r3/HEAD
fatal: unable to connect to github.com:
github.com[0: 192.30.253.113]: errno=Connection refused
github.com[1: 192.30.253.112]: errno=Connection refused

 * ERROR: sci-biology/freebayes-9999::science failed (unpack phase):
 *   Unable to fetch from any of EGIT_REPO_URI
 * 
 * Call stack:
 *     ebuild.sh, line  115:  Called src_unpack
 *   environment, line 2602:  Called git-r3_src_unpack
 *   environment, line 1861:  Called git-r3_src_fetch
 *   environment, line 1855:  Called git-r3_fetch
 *   environment, line 1777:  Called die
 * The specific snippet of code:
 *       [[ -n ${success} ]] || die "Unable to fetch from any of EGIT_REPO_URI";
 * 
 * If you need support, post the output of `emerge --info '=sci-biology/freebayes-9999::science'`,
 * the complete build log and the output of `emerge -pqv '=sci-biology/freebayes-9999::science'`.
 * The complete build log is located at '/apps/gentoo/var/tmp/portage/sci-biology/freebayes-9999/temp/build.log'.
 * The ebuild environment file is located at '/apps/gentoo/var/tmp/portage/sci-biology/freebayes-9999/temp/environment'.
 * Working directory: '/apps/gentoo/var/tmp/portage/sci-biology/freebayes-9999/work'
 * S: '/apps/gentoo/var/tmp/portage/sci-biology/freebayes-9999/work/freebayes-9999'


BTW: I see in science overlay a lot of ebuilds referring to both, git:// and https:// URIs. Did you promote only one can be defined and that the other is tried automagically?

One example:

dev-python/ipywidgets/ipywidgets-9999.ebuild:EGIT_REPO_URI="https://github.com/ipython/${PN}.git git://github.com/ipython/${PN}.git"
Comment 3 Martin Mokrejš 2017-04-06 23:37:38 UTC
Aha, just in case the fix is not yet in Gentoo::RAP. ;-)


$ emerge --info '=sci-biology/freebayes-9999'
Portage 2.3.3 (python 2.7.12-final-0, prefix/linux-standalone/amd64, gcc-4.9.4, glibc-2.24-r1, 2.6.32-573.26.1.100hz.el6.noc0w.x86_64 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-2.6.32-573.26.1.100hz.el6.noc0w.x86_64-x86_64-Intel-R-_Xeon-R-_CPU_E5-4627_v2_@_3.30GHz-with-redhat-6.7-Santiago
KiB Mem:  3333697708 total,3257375820 free
KiB Swap:    7812028 total,   7812028 free
Timestamp of repository gentoo: Thu, 06 Apr 2017 23:00:01 +0000
sh bash 4.4_p12
ld GNU ld (Gentoo 2.27 p1.0) 2.27
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.1_rc4::gentoo
dev-lang/python:          2.7.12::gentoo, 3.4.5::gentoo
dev-util/cmake:           3.7.2::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/sandbox:         2.10-r3::gentoo
sys-devel/autoconf:       2.69-r2::gentoo
sys-devel/automake:       1.15-r2::gentoo
sys-devel/binutils:       2.27::gentoo
sys-devel/gcc:            4.9.4::gentoo, 5.4.0-r3::gentoo
sys-devel/gcc-config:     1.8_p20160608::rap
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.9::gentoo (virtual/os-headers)
sys-libs/glibc:           2.24-r1::gentoo
Repositories:

gentoo
    location: /apps/gentoo/usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    eclass-overrides: rap

rap
    location: /apps/gentoo/usr/portage-stage
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/android.git
    masters: gentoo
    eclass-overrides: rap

haskell
    location: /apps/gentoo/var/lib/layman/haskell
    masters: gentoo
    priority: 50
    eclass-overrides: rap

science
    location: /apps/gentoo/var/lib/layman/science
    masters: gentoo
    priority: 50
    eclass-overrides: rap

ACCEPT_KEYWORDS="amd64 ~amd64 ~amd64-linux"
ACCEPT_LICENSE="* -@EULA dlj-1.1 sun-bcla-java-vm Oracle-BCLA-JavaSE IBM-J1.6 skype-eula Nero-EULA-US AdobeFlash-10.3 skype-4.0.0.7-copyright AdobeFlash-11.x Intel-SDP OPERA-2014"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.3/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -O2 -pipe -march=native"
DISTDIR="/apps/gentoo/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles force-prefix merge-sync news nostrip parallel-fetch preserve-libs protect-owned sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans unprivileged"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.fi.muni.cz/pub/linux/gentoo/ http://gentoo.mirror.web4u.cz/ rsync://gentoo.mirror.dkm.cz/gentoo/ ftp://gentoo.mirror.web4u.cz/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/apps/gentoo/usr/portage/packages"
PORTAGE_CONFIGROOT="/apps/gentoo/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/apps/gentoo/var/tmp"
USE="X alsa amd64 apache apache2 avx avx2 berkdb boost bzip2 cairo cgi cli coin cracklib crypt cryptlib cxx dbus device-mapper dhcp dri emboss encode fax fbcon ffmpeg fontconfig fortran gbm gd gdbm gimp glpk gnutls gtk hal hwdb iconv imaging innodb ithreads java javafx javascript jce jpeg jpg js jscript keymap ladspa lapack lcms libnotify lm_sensors mad mmx modules mpi mpich2 mysql ncurses nfs nls nptl nptlonly nscd objc openmp openssl pcre pdf perl php png policykit polkit ppds pppd prefix python qt3support readline resolvconf seccomp server session slideshow sndfile sqlite sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 suexec svg syslog tcl tcpd threads tiff tk truetype unicode usb v4l v4l2 vim-syntax vnc wavpack wifi x11 xcb xml xorg xrandr xv xvid xvmc zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en_US en_GB en cs" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

sci-biology/freebayes-9999::science was built with the following:
USE="(prefix)"