Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 593542 - app-editors/scite-4.0.2 - Version bump
Summary: app-editors/scite-4.0.2 - Version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ervin Peters
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2016-09-12 07:25 UTC by Ervin Peters
Modified: 2017-11-17 00:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
scite-3.6.7.ebuild (scite-3.6.7.ebuild,2.61 KB, text/plain)
2016-09-12 07:25 UTC, Ervin Peters
Details
fixed scite-4.0.2.ebuild (scite-4.0.2.ebuild,2.62 KB, text/plain)
2017-11-12 12:15 UTC, Ervin Peters
Details
fixed scite-4.0.2.ebuild - xdg_desktop_database_update (scite-4.0.2.ebuild,2.71 KB, text/plain)
2017-11-12 22:52 UTC, Ervin Peters
Details
fixed scite-4.0.2.ebuild (scite-4.0.2.ebuild,2.72 KB, text/plain)
2017-11-13 18:09 UTC, Ervin Peters
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ervin Peters 2016-09-12 07:25:52 UTC
Created attachment 445506 [details]
scite-3.6.7.ebuild

New version available. Attached an ebuild.

related open problem: Bug #576162

Which dir does eapply_user expect?

ervin
Comment 1 Coacher 2016-09-12 17:45:48 UTC
(In reply to Ervin Peters from comment #0)
> Which dir does eapply_user expect?
Patches are applied with '-p1' in the current working directory, which is ${S} by default.
Comment 2 Jonas Stein gentoo-dev 2017-11-11 18:00:23 UTC
Sorry, that this ticket got lost so long. 

I had a short look on the ebuild. 
Here a few ideas:

• Please test the ebuild with repoman https://wiki.gentoo.org/wiki/Repoman

• please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)

If you like, join our IRC channel #gentoo-proxy-maint we can discuss your ebuild and open questions there so that we get this merged soon. Best, JS
Comment 3 Ervin Peters 2017-11-12 12:11:25 UTC
(In reply to Jonas Stein from comment #2)
> Sorry, that this ticket got lost so long. 
> 
> I had a short look on the ebuild. 
> Here a few ideas:
> 
> • Please test the ebuild with repoman https://wiki.gentoo.org/wiki/Repoman

done, fixed a few things

> • please fix the header. (see /usr/portage/skel.ebuild and
> https://devmanual.gentoo.org/ebuild-writing/eapi/)

done
 
> If you like, join our IRC channel #gentoo-proxy-maint we can discuss your
> ebuild and open questions there so that we get this merged soon. Best, JS

... is it common there to chat bidirectional or better to the whole group?

SciTE is now at 4.02, the ebuild will be attached soon.

ervin (IRC: dermoench42)
Comment 4 Ervin Peters 2017-11-12 12:15:01 UTC
Created attachment 503706 [details]
fixed scite-4.0.2.ebuild

updated ebuild:

- using gt3 as stated out in https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies

- current 4.0.2 version

ervin
Comment 5 Manfred Knick 2017-11-12 14:31:09 UTC
(In reply to Ervin Peters from comment #4)
> Created attachment 503706 [details]
> fixed scite-4.0.2.ebuild

Applied as

. . . /usr/local/portage/local-overlay/app-editors/scite/scite-4.0.2.ebuild

Confirmation:  WORKSFORME

Thanks to Ervin.
Comment 6 Jonas Stein gentoo-dev 2017-11-12 21:57:24 UTC
when installing 4.0.2

 * QA Notice: .desktop files with MimeType= were found installed
 * but desktop mimeinfo cache has not been updated:
 *   /usr/share/applications/SciTE.desktop
 * Please make sure to call xdg_desktop_database_update()
 * in pkg_postinst() and pkg_postrm() phases of appropriate pkgs.

will need a fix for all versions.
Comment 7 Ervin Peters 2017-11-12 22:52:56 UTC
Created attachment 503824 [details]
fixed scite-4.0.2.ebuild - xdg_desktop_database_update

... inserted the xdg_desktop_database_update functions ...

Suggest to remove the 3.6.x versions, because there are no special needs to keep them.

ervin
Comment 8 Jonas Stein gentoo-dev 2017-11-12 23:20:18 UTC
Please test your contributions before submission.
(with repoman and installation)
This time it failed too, because xdg-utils is not in the inherit line.

https://devmanual.gentoo.org/eclass-reference/xdg-utils.eclass/

If you try to install it, you will see the error messages in the end.
Comment 9 Jonas Stein gentoo-dev 2017-11-13 01:56:44 UTC
Hi Ervin, I am very confused now with the xdg thing. I have discussed it with several developers now, something is strange. I will try to figure it out within the next weeks.
Every proxy maintainer can continue here. 
Please ping us, if the ebuild was not merged in the next 2 weeks. Best, JS
Comment 10 Ervin Peters 2017-11-13 09:47:34 UTC
Oh, sorry for that!
I only looked for QA notices during test builds. I didn't see the command not found error.

I inserted the xdg-utils eclass in the inherit line and compiled 4.0.2 with no error.

But a few thoughts then:

The QA-observer recognizes an installation to the Desktop-Files location, because portage tracks every file.
Wouldn't it be easier for the whole gentoo world to do necessary update actions depending on filechanges in 'special Folders' automagically? Because they mainly depend on the system, the system is responsible for it and the ebuild provider could not know every possible context? (It seems to me the goal of such abstraction layers and standards ;)

After some additional tests I'll upload corrected ebuilds for 3.5.5 and 4.02

Ervin
Comment 11 Manfred Knick 2017-11-13 13:07:46 UTC
(In reply to Ervin Peters from comment #7)
> Suggest to remove the 3.6.x versions, because there are no special needs to
> keep them.
3.5.5 ?

# equery list -p scite

[-P-] [  ] app-editors/scite-3.5.5:0
[-P-] [  ] app-editors/scite-3.6.2-r1:0
[-P-] [  ] app-editors/scite-3.6.4-r1:0
[-P-] [  ] app-editors/scite-3.6.5-r1:0
Comment 12 Ervin Peters 2017-11-13 18:09:33 UTC
Created attachment 503862 [details]
fixed scite-4.0.2.ebuild

Correct inherit lines, compiles und installs without complains, also on a gentoo Minimal - means dependencies are ok..

3.5.5 is marked as stable. If possible leave it until 4.0.2 becomes stable. eventually add the missing xdg dependencies. the 4.02 ebuild should word with any version down to 3.5.5, since the internal structures only differs on switching to gtk3+.

ervin
Comment 13 Jonas Stein gentoo-dev 2017-11-15 22:27:56 UTC
commit 1623f7367ad0ad21ee210a11ddc4aa06cd375fce

    app-editors/scite: Version bump to 4.0.2
    
    Version bump to 4.0.2
    bump to EAPI=6
    add missing xdg-utils eclass
    
    Package-Manager: Portage-2.3.13, Repoman-2.3.4