591580 – waf-utils.eclass should respect "$@" in waf-utils_src_install()

Bug 591580 - waf-utils.eclass should respect "$@" in waf-utils_src_install()

Summary: waf-utils.eclass should respect "$@" in waf-utils_src_install()

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement with 1 vote (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-08-18 07:33 UTC by begdory4
Modified:	2019-03-17 18:49 UTC (History)
CC List:	4 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description begdory4 2016-08-18 07:33:21 UTC

waf-utils_src_install uses following command, but there is no way to add an argument there.
"${WAF_BINARY}" --destdir="${D}" install  || die "Make install failed"
it possibly should be like 
"${WAF_BINARY}" --destdir="${D}" install "$@" || die "Make install failed"
as waf-utils_src_config

Comment 1 Daniel M. Weeks 2017-08-22 02:33:40 UTC

I have also run into this and agree it's a problem that should be corrected. The same problem should be fixed in waf-utils_src_compile as well.

Comment 2 Michał Górny archtester

2019-03-17 18:49:11 UTC

commit d15df4e625dadba62838a9b0ab5e1ffa88715db3
Author:     ktrace <ktrace@yandex.ru>
AuthorDate: Sat Sep 22 14:53:16 2018
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Tue Oct 9 21:59:41 2018

    waf-utils.eclass: add parameters to compile and install
    
    Signed-off-by: Victor Kustov <ktrace@yandex.ru>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>