All dictionary packages for myspell/hunspell follow the naming scheme app-dicts/myspell-${lang} and so should this one. Furthermore, a dependency on the package in app-text/hunspell is missing. So, we should: 1. Rename hunspell-kk to myspell-kk (Note, *no* package move, because I don't want to burn the name hunspell-kk for the case that somebody wants to do a global move from myspell-* to hunspell-* a some later time.) 2. Keyword myspell-kk (can be done with ALLARCHES, I suppose) 3. Add dependency on myspell-kk to hunspell.
Also, looking at hunspell-kk-1.1.2.ebuild, I see multiple QA violations: 1. vcs-snapshot.eclass is not needed, the default src_unpack will just work fine. (eutils and git-r3 have already been removed from inherit by another QA member, because they were unnecessary too.) 2. MY_P=${PN}-${PV} is the default for P, so it is not needed. 3. Canonical ordering of variables should be used, e.g. DESCRIPTION/HOMEPAGE/SRC_URI in the first block. 4. LICENSE is not accurate, it is GPL version 2 or later, and similar for LGPL. 5. IUSE: Why are these USE flags there? None of them is used. 6. RDEPEND: What are ncurses and readline needed for? 7. DEPEND: The ebuild doesn't actually build anything, so there shouldn't be any build-time dependencies at all. 8. S=${WORKDIR}/${MY_P} Again, this is the default, therefore not needed. 9. src_install: Is it necessary to install all three dictionaries? What is the purpose of kk_test.* and kk_noun_adj.*? 10. There actually exists myspell-r2.eclass which is a close to perfect tool for dictionary packages like this. AFAICS, it would allow for an ebuild with only variables but without any phase functions. Finally, looking at the package itself, files kk_KZ.* are shipped with MS-DOS line endings and starting with a byte-order mark (which is bogus for UTF-8).
Hi, I'll rewrite this package ebuild soon (In reply to Ulrich Müller from comment #1) > 9. src_install: Is it necessary to install all three dictionaries? What is > the purpose of kk_test.* and kk_noun_adj.*? kk_test.* contains fixes for rules of the description, also it contains rules and tests for adjectives. Probably it is a good idea to move them into main dictionary files > Finally, looking at the package itself, files kk_KZ.* are shipped with > MS-DOS line endings and starting with a byte-order mark (which is bogus for > UTF-8). I'll try change charset of these files to UTF-8.
Created attachment 452043 [details] myspell-kk-1.1.2.ebuild About adding the dependency to app-text/hunspell: I have no permissions to change it. I can only made custom ebuild for app-text/hunspell with added app-dicts/myspell-kk.
Created attachment 452049 [details] myspell-kk-1.1.2.ebuild
commit 4bf4f37c07ad8dc56944eeeefb9d852edc4b17b3 Author: Ulrich Müller <ulm@gentoo.org> Date: Tue Nov 1 11:43:12 2016 +0100 app-dicts/myspell-kk: [QA] Package renamed from hunspell-kk. Ebuild rewritten from scratch, based on work by Galym Kerimbekov. Note that this is not a pkgmove because we don't want to "burn" hunspell-kk as a package name, for the case that myspell-* would be moved to hunspell-* later. Bug: 586788 Package-Manager: portage-2.3.2 Arch teams, please keyword app-dicts/myspell-kk, so that we can update dependencies in app-text/hunspell. Target keywords: app-dicts/myspell-kk-1.1.2: ~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~amd64-fbsd ~x86-fbsd Please note the ALLARCHES keyword.
~ia64 keyworded ulm@ please consider populating 'Package list' to speedup keywording.
keyworded 1.1.2 for alpha/arm/hppa/mips/ppc/ppc64/sh/sparc/amd64-fbsd/x86-fbsd
(In reply to Sergei Trofimovich from comment #6) > ~ia64 keyworded > > ulm@ please consider populating 'Package list' to speedup keywording. Right. This bug was filed before introduction of the package list and for some reason it went under my radar. Thanks for noticing.
> So, we should: > > 1. Rename hunspell-kk to myspell-kk > (Note, *no* package move, because I don't want to burn the name hunspell-kk > for the case that somebody wants to do a global move from myspell-* to > hunspell-* a some later time.) > > 2. Keyword myspell-kk (can be done with ALLARCHES, I suppose) This part has been completed. > 3. Add dependency on myspell-kk to hunspell. Still to be done (and waiting for stabilisation in bug 626634). Reopening.
All done. Closing.
