Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 582862 - =net-p2p/pybitmessage-0.6.0: version bump, =net-p2p/pybitmessage-0.6.0-r1 (qt5/qt4)
Summary: =net-p2p/pybitmessage-0.6.0: version bump, =net-p2p/pybitmessage-0.6.0-r1 (qt...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://github.com/Bitmessage/PyBitme...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-12 21:09 UTC by ng0
Modified: 2017-05-12 21:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pybitmessage-0.6.0.ebuild (pybitmessage-0.6.0.ebuild,1.53 KB, text/plain)
2016-05-12 21:10 UTC, ng0
Details
pybitmessage-0.6.0-r1.ebuild (pybitmessage-0.6.0-r1.ebuild,1.62 KB, text/plain)
2016-06-05 21:48 UTC, ng0
Details
metadata.xml (metadata.xml,1.18 KB, text/xml)
2016-06-05 21:49 UTC, ng0
Details
pybitmessage-0.6.0-r1.ebuild (pybitmessage-0.6.0-r1.ebuild,1.69 KB, text/plain)
2016-06-06 15:47 UTC, ng0
Details
My ebuild for pybitmessage-0.6.1 (pybitmessage-0.6.1-r2.ebuild,1.93 KB, text/plain)
2017-02-28 21:23 UTC, Dmitri Bogomolov
Details
pybitmessage-0.6.2_p20170416.ebuild (pybitmessage-0.6.2_p20170416.ebuild,1.77 KB, text/plain)
2017-04-18 11:23 UTC, Dmitri Bogomolov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ng0 2016-05-12 21:09:43 UTC
New release version of PyBitmessage, this ebuild adds 0.6.0 with no changes to the ebuild but the version extension.

Reproducible: Always
Comment 1 ng0 2016-05-12 21:10:49 UTC
Created attachment 434112 [details]
pybitmessage-0.6.0.ebuild
Comment 2 ng0 2016-05-19 16:15:12 UTC
I have not finished reconfiguring the entire system with libressl, but so far that I emerged pybitmessage-0.6 successfully with +libressl, receiving messages worked, sending was not yet tested.
Comment 3 ng0 2016-05-22 20:26:15 UTC
0.6 is building functional with libressl, receiving messages works, sending messages works.

I want to adopt this package through proxy-maint since it is on maintainer needed status now.
Comment 4 Pacho Ramos gentoo-dev 2016-05-28 11:07:20 UTC
CCing proxy-maint to allow you to push the work in the tree, thanks
Comment 5 ng0 2016-06-05 21:48:45 UTC
Created attachment 436586 [details]
pybitmessage-0.6.0-r1.ebuild

pybitmessage 0.6.0-r1.ebuild - fix with libressl IUSE syntax.
Tested qt5 build in addition to the old, qt4 only build.
So far it has been operational on two amd64 systems, one vanilla, one hardened, sending messages back and forth between them, syncing/receiving from lists,..

I send this in as -r1 and not obsoleting in case someone is against this change.
One of the core developers of bitmessage is looking to drop pyqt4 or make pyqt4 optional, with what I tested today it might be easier than they think.
Comment 6 ng0 2016-06-05 21:49:50 UTC
Created attachment 436588 [details]
metadata.xml

metadata.xml - iirc hasufell left this and I'm taking this over. added myself and proxy-maint project.
Comment 7 ng0 2016-06-05 21:52:28 UTC
I made this ~amd64 only as I only tested on amd64. Running on x86 and pushing the eapi to eapi6 will be the next thing I work on, so far I consider this done as it is no new ebuild, but an ebuild with adjustments.
Comment 8 ng0 2016-06-06 15:19:26 UTC
> PyBitmessage does not need to be adjusted,
> building it with PyQt5 worked and I will update the ebuild later
> tonight or tomorrow.
Are you sure it's actually using PyQt5? Because the sources are like:
from PyQt4 import QtCore, QtGui
If you want to use PyQt5, you would have to do something like:
from PyQt5.QtWidgets import QApplication, QWidget

Based on the qt4 to qt5 transition document in qt wiki, you have to replace QtGui with QtWidgets.

Peter




Based on this I noticed I greped wrong, and I'll write a patch for pyqt5 support.
Comment 9 ng0 2016-06-06 15:47:42 UTC
Created attachment 436658 [details]
pybitmessage-0.6.0-r1.ebuild

PyQt5 does not easily work and pybitmessage needs to be patched.
Comment 10 ng0 2016-06-17 23:25:32 UTC
I hereby pull back my request to become maintainer as I can't maintain works (and most importantly, double work sometimes) on two OS.

Whoever likes to pick it up, feel free to do so.
Comment 11 Dmitri Bogomolov 2017-02-28 21:23:14 UTC
Created attachment 465614 [details]
My ebuild for pybitmessage-0.6.1

You missed many dependencies, particularly the most important - dev-python/msgpack.

But there is a good news: maybe in ebuild for 0.6.2 it will be possible to inherit distutils-r1 because the setup.py script is already merged on github.
Comment 12 Dmitri Bogomolov 2017-04-18 11:23:17 UTC
Created attachment 470308 [details]
pybitmessage-0.6.2_p20170416.ebuild

Ebuild for the most recent PyBitmessage code with linguas.
Comment 13 Michael Orlitzky gentoo-dev 2017-04-28 01:12:34 UTC
Hi Dmitri, I've committed v0.6.2 to the tree largely based on your ebuild:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd06526466c9f14b5abce4730843a1452c028819

There were a few differences that I'd like to resolve, mainly,

  1. Is dev-python/qrcode actually used? I left it out because
     I couldn't find where it was used.

  2. Same thing for media-libs/gst-plugins-base.

Other than that, I am requiring some kind of SSL support because setup.py checks for it, and I left out the LINGUAS handling for simplicity.

Let me know how the new (EAPI=6) version works for you and we can improve it from there.
Comment 14 Dmitri Bogomolov 2017-04-28 19:27:56 UTC
(In reply to Michael Orlitzky from comment #13)
> Hi Dmitri, I've committed v0.6.2 to the tree largely based on your ebuild:
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=cd06526466c9f14b5abce4730843a1452c028819
> 
> There were a few differences that I'd like to resolve, mainly,
> 
>   1. Is dev-python/qrcode actually used? I left it out because
>      I couldn't find where it was used.
> 
>   2. Same thing for media-libs/gst-plugins-base.
> 
> Other than that, I am requiring some kind of SSL support because setup.py
> checks for it, and I left out the LINGUAS handling for simplicity.
> 
> Let me know how the new (EAPI=6) version works for you and we can improve it
> from there.

I agree on all the points.

This ebuild is taken from my overlay, which I use to install my new code for testing before PR to pybitmessage's v0.6 branch. In commit, I used in this ebuild qrcode patch was already merged as well as setup.py fix. I planned to use gst-play-1.0 from media-libs/gst-plugins-base for sound notification in default plugin but this code is not ready to PR yet - I just forgot to clean this dependency out. OpenSSL is probably not optional but I'm not 100% sure.

With EAPI=6 I got this:

 * ERROR: net-p2p/pybitmessage-0.6.2_p20170416-r1::altcoins failed (prepare phase):
 *   eapply_user (or default) must be called in src_prepare()!
 * 
 * Call stack:
 *            ebuild.sh, line  767:  Called __ebuild_main 'prepare'
 *   phase-functions.sh, line 1007:  Called __dyn_prepare
 *   phase-functions.sh, line  382:  Called die
 * The specific snippet of code:
 *   		die "eapply_user (or default) must be called in src_prepare()!"

the ebuild origin: https://github.com/g1itch/altcoins-overlay/tree/master/net-p2p/pybitmessage
Comment 15 Michael Orlitzky gentoo-dev 2017-05-01 13:55:26 UTC
Ok, the committed ebuild should be fine then. Thanks for your help.
Comment 16 Dmitri Bogomolov 2017-05-12 10:46:18 UTC
Regarding that new ebuild in tree, one remark: pybitmessage requires one of media-sound/alsa-utils media-sound/gst123 media-sound/mpg123 to play sounds - not all them.
Comment 17 Dmitri Bogomolov 2017-05-12 10:53:34 UTC
And media-sound/gst123 is the best choice so probably should be the first in this list.
Comment 18 Michael Orlitzky gentoo-dev 2017-05-12 21:33:56 UTC
thanks =)

commit 74d4c08659c27a4d0733966470505b56319424ee
Author: Michael Orlitzky <mjo@gentoo.org>
Date:   Fri May 12 17:32:33 2017 -0400

    net-p2p/pybitmessage: new revision to fix audio dependencies.

    In v0.6.2, I had an "and" dependency on a few audio tools that should
    have been an "or" dependency. Thanks to Dmitri Bogomolov for catching
    the mistake and suggesting the correct fix.

    Package-Manager: Portage-2.3.3, Repoman-2.3.1