Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 581268 - www-servers/apache-2.4.* proxy_html module should perhaps depend on mod_xml2enc?
Summary: www-servers/apache-2.4.* proxy_html module should perhaps depend on mod_xml2enc?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 14:20 UTC by Russell Knighton
Modified: 2017-06-17 21:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add xml2enc in-tree module, add it as dependency for proxy_html (xml2enc.patch,782 bytes, patch)
2017-05-16 09:20 UTC, E. Scaglione
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Knighton 2016-04-26 14:20:18 UTC
This ir related, in part, to bug #575410

When running apache with "-D PROXY_HTML" enabled, the following warning is always displayed when starting/stopping apache:

[Tue Apr 26 13:35:11.996531 2016] [proxy_html:notice] [pid 18051:tid 140214397339520] AH01425: I18n support in mod_proxy_html requires mod_xml2enc. Without it, non-ASCII characters in proxied pages are likely to display incorrectly.

The warning is stopped be installing and enabling the xml2enc module.

Apache seems to continue to run fine without xml2enc, and proxy_html also appears to work, however this error message does state "requires" and I can't think of any reason why anyone wouldn't want this; therefore, I propose that a dependency be added on www-apache/mod_xml2enc whenever apache2_modules_proxy_html is included.

The required change would be:
-DEPEND+="apache2_modules_http2? ( >=net-libs/nghttp2-1.2.1 )"
+DEPEND+="apache2_modules_http2? ( >=net-libs/nghttp2-1.2.1 )
+        apache2_modules_proxy_html? ( www-apache/mod_xml2enc )"

It would also then be prudent to somehow automatically enable mod_xml2enc when PROXY_HTML is enabled. I don't think it's possible to do a "<IfDefine XML2ENC or PROXY_HTML>", so what would be the best way to achieve this? Or should we just give an einfo notice advising people to enable XML2ENC if enabling PROXY_HTML?
Comment 1 Timo Eissler 2016-12-09 15:26:25 UTC
The definition of "-D PROXY_HTML" isn't comming from the www-servers/apache ebuild, so the described message appears when "-D PROXY" (which is the default definition of mod_proxy_html) is used.
Comment 2 E. Scaglione 2017-05-16 09:20:35 UTC
Created attachment 472760 [details, diff]
Add xml2enc in-tree module, add it as dependency for proxy_html

mod_proxy_html requires the xml2enc module shipped with Apache 2.4, the off-tree module is for Apache 2.2 and do not work with apache 2.4/do not fix the problem with mod proxy_html.
To fix the problem xml2enc needs to be added to the list of modules.

2 lines patch attached.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-06-17 21:35:53 UTC
Fixed in =www-servers/apache-2.4.26