Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 576090 - games-emulation/dolphin-9999: Revision shouldn't be overridden
Summary: games-emulation/dolphin-9999: Revision shouldn't be overridden
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Devan Franchini (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 12:22 UTC by Tear♪
Modified: 2016-06-25 02:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tear♪ 2016-03-01 12:22:20 UTC
Line 142 of dolphin-9999.ebuild contains:
"-DDOLPHIN_WC_REVISION=${PV}"

I believe this line should be removed, as it removes git version information from the title bar and "About" popup and replaces it with 9999. It's quite important to know what revision you're running when submitting issues or game tests upstream. Additionally, the netplay function intentionally refuses to connect clients with different revisions to ensure compatibility and stability, so this line makes it impossible for a Gentoo user to connect to anyone other than another Gentoo user, and might result in instability if their revisions differ.

With this line removed, the version string becomes dolphin-4.0-9050-dirty (as of the time of writing). The "-dirty" suffix does not break compatibility with users of official packages.
Comment 1 Devan Franchini (RETIRED) gentoo-dev 2016-03-05 05:10:54 UTC
Sounds like a reasonable thing to remove. I'll be removing that then.
Comment 2 Devan Franchini (RETIRED) gentoo-dev 2016-03-05 05:54:30 UTC
Done and done, I'll keep this open until tomorrow to ensure it goes through.