Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571546 - app-portage/repoman - use more predictable filenames for editor's commit message files
Summary: app-portage/repoman - use more predictable filenames for editor's commit mess...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL: https://archives.gentoo.org/gentoo-po...
Whiteboard:
Keywords:
Depends on:
Blocks: 612774
  Show dependency tree
 
Reported: 2016-01-11 14:49 UTC by Coacher
Modified: 2018-09-22 21:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2016-01-11 14:49:01 UTC
Hello.

Please create temporary files for editor's commit messages with '.repoman.msg' suffix here: https://github.com/gentoo/portage/blob/39cc561ed9989798f78eacf42052ff276da1497b/pym/repoman/utilities.py#L190

The same way it's already done here: https://github.com/gentoo/portage/blob/39cc561ed9989798f78eacf42052ff276da1497b/pym/repoman/actions.py#L638 and here: https://github.com/gentoo/portage/blob/39cc561ed9989798f78eacf42052ff276da1497b/pym/repoman/actions.py#L685

This helps to create filetype-based rules in editors like Vim to automatically enable spelling and syntax highlighting.
Comment 1 Coacher 2017-03-15 16:43:43 UTC
The patch was sent to ML almost a year ago and passed review (see URL).
I've asked dol-sen several times on IRC to merge it without any effect.
What prevents this patch from being merged and this patch finally fixed?
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2017-03-15 21:59:42 UTC
Sorry, this patch/emails got dropped in the wrong directory, so didn't see them on my todo, got forgotten about.  I had to search to find it.

Pushed in commit: fd893603470071e5657e381f4461ee11a31474d6
Comment 3 Zac Medico gentoo-dev 2017-05-20 19:21:36 UTC
Fixed in portage-2.3.5.
Comment 4 Zac Medico gentoo-dev 2017-05-20 19:25:39 UTC
Actaully, this is a repoman bug.
Comment 5 Zac Medico gentoo-dev 2018-09-22 21:40:34 UTC
Fixed in repoman-2.3.3.