Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 565912 - Truncated entry in generated ChangeLog
Summary: Truncated entry in generated ChangeLog
Status: RESOLVED OBSOLETE
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - External Interaction (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-16 10:03 UTC by Ulrich Müller
Modified: 2022-01-10 10:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-11-16 10:03:15 UTC 
For this commit:

commit 51f6894c25eca0295917e2bd832f144b108efabf
Author: Ulrich Müller <ulm@gentoo.org>
Date:   Mon Nov 16 07:32:00 2015 +0100

    sys-apps/busybox: [QA] Trigger a rebuild of the broken Manifest.
    
    Add a notice that license is really GPL-2 only.
    
    Package-Manager: portage-2.2.24

... this is what has landed in the generated ChangeLog:

  16 Nov 2015; Ulrich Müller <ulm@gentoo.org> busybox-1.24.1.ebuild,
  busybox-9999.ebuild:
  QA] Trigger a rebuild of the broken Manifest.

  Add a notice that license is really GPL-2 only.

  Package-Manager: portage-2.2.24

Note the mangled [QA] tag.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-11-17 00:39:45 UTC 
Infra just runs the egencache script, and does not mangle changelogs manually, which means this is a bug in that script...
Comment 2 Zac Medico gentoo-dev 2015-11-17 00:58:59 UTC 
The relevant code is as follows:

    # strip '<cp>: ', '[<cp>] ', and similar
    body[0] = re.sub(r'^\W*' + re.escape(cp) + r'\W+', '', body[0])

If can change the r'\W+' pattern to r'[:\s]*' then it will only strip colons and whitespace, leaving [QA] intact.
Comment 3 Ulrich Müller gentoo-dev 2015-11-17 06:10:15 UTC 
(In reply to Zac Medico from comment #2)
> The relevant code is as follows:
> 
>     # strip '<cp>: ', '[<cp>] ', and similar
>     body[0] = re.sub(r'^\W*' + re.escape(cp) + r'\W+', '', body[0])
> 
> If can change the r'\W+' pattern to r'[:\s]*' then it will only strip colons
> and whitespace, leaving [QA] intact.

It is QA policy to tag our commits with "[QA]" or "QA:". Please change the code in a way that both will be preserved.
Comment 4 Ulrich Müller gentoo-dev 2022-01-10 10:21:53 UTC 
We no longer use ChangeLogs. Closing.