Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 563796 - dev-util/valgrind: doesn't support TBM instructions
Summary: dev-util/valgrind: doesn't support TBM instructions
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-10-22 14:16 UTC by Török Edwin
Modified: 2023-09-04 23:11 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Török Edwin 2015-10-22 14:16:23 UTC
I'm reporting this to save time should someone encounter this problem with a similar CPU.

Using -march=native with an AMD FX(tm)-8350 CPU makes valgrind impossible to use:
CFLAGS="-march=native -O2 -pipe -ggdb"

The problematic instruction appears to be 'bextr' which should be part of BMI but using '-mno-bmi' doesn't help because GCC still generates 'bextr'.

The solution to produce code that valgrind can run was to use '-march=native -mno-tbm'.

Reproducible: Always

Steps to Reproduce:
1. add -march=native to CFLAGS in /etc/portage/make.conf and emerge glibc or bash
2. Run valgrind /bin/ls or valgrind bash
Actual Results:  
 vex amd64->IR: unhandled instruction bytes: 0x8F 0xEA 0xF8 0x10 0xC9 0x3 0x1D 0x0
vex amd64->IR:   REX=0 REX.W=0 REX.R=0 REX.X=0 REX.B=0
vex amd64->IR:   VEX=0 VEX.L=0 VEX.nVVVV=0x0 ESC=NONE
vex amd64->IR:   PFX.66=0 PFX.F2=0 PFX.F3=0
==23402== valgrind: Unrecognised instruction at address 0x4011d04.
==23402==    at 0x4011D04: _dl_allocate_tls_storage (dl-tls.c:379)
==23402==    by 0x4000B9A: init_tls (rtld.c:622)
==23402==    by 0x40034AF: dl_main (rtld.c:1683)
==23402==    by 0x4016978: _dl_sysdep_start (dl-sysdep.c:249)
==23402==    by 0x4004C28: _dl_start_final (rtld.c:307)
==23402==    by 0x4004C28: _dl_start (rtld.c:413)
==23402==    by 0x4000C47: ??? (in /lib64/ld-2.22.so)

Expected Results:  
valgrind running the application

Working emerge --info:

Portage 2.2.23 (python 3.4.3-final-0, default/linux/amd64/13.0, gcc-4.9.3, glibc-2.22-r1, 4.0.5-gentoo x86_64)
=================================================================
System uname: Linux-4.0.5-gentoo-x86_64-AMD_Opteron_63xx_class_CPU-with-gentoo-2.2
KiB Mem:     5970092 total,   2029132 free
KiB Swap:     524284 total,    524284 free
Timestamp of repository gentoo: Thu, 22 Oct 2015 13:30:01 +0000
sh bash 4.3_p42
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p42::gentoo
dev-lang/perl:            5.22.0::gentoo
dev-lang/python:          2.7.10::gentoo, 3.4.3::gentoo
dev-util/cmake:           3.3.2-r1::gentoo
dev-util/pkgconfig:       0.29::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.18.3::gentoo
sys-apps/sandbox:         2.9::gentoo
sys-devel/autoconf:       2.69-r1::gentoo
sys-devel/automake:       1.13.4::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo
sys-devel/gcc-config:     1.8::gentoo
sys-devel/libtool:        2.4.6-r1::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.2::gentoo (virtual/os-headers)
sys-libs/glibc:           2.22-r1::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

ACCEPT_KEYWORDS="amd64 ~x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -ggdb -mno-tbm"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe -ggdb -mno-tbm"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 berkdb bindist bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mmx mmxext modules multilib ncurses nls nptl openmp pam pcre readline seccomp session sse sse2 ssl tcpd unicode xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Anthony Basile gentoo-dev 2015-10-26 01:24:15 UTC
(In reply to Torok Edwin from comment #0)
> I'm reporting this to save time should someone encounter this problem with a
> similar CPU.
> 
> Using -march=native with an AMD FX(tm)-8350 CPU makes valgrind impossible to
> use:
> CFLAGS="-march=native -O2 -pipe -ggdb"
> 
> The problematic instruction appears to be 'bextr' which should be part of
> BMI but using '-mno-bmi' doesn't help because GCC still generates 'bextr'.
> 
> The solution to produce code that valgrind can run was to use '-march=native
> -mno-tbm'.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. add -march=native to CFLAGS in /etc/portage/make.conf and emerge glibc or
> bash
> 2. Run valgrind /bin/ls or valgrind bash
> Actual Results:  
>  vex amd64->IR: unhandled instruction bytes: 0x8F 0xEA 0xF8 0x10 0xC9 0x3
> 0x1D 0x0
> vex amd64->IR:   REX=0 REX.W=0 REX.R=0 REX.X=0 REX.B=0
> vex amd64->IR:   VEX=0 VEX.L=0 VEX.nVVVV=0x0 ESC=NONE
> vex amd64->IR:   PFX.66=0 PFX.F2=0 PFX.F3=0
> ==23402== valgrind: Unrecognised instruction at address 0x4011d04.
> ==23402==    at 0x4011D04: _dl_allocate_tls_storage (dl-tls.c:379)
> ==23402==    by 0x4000B9A: init_tls (rtld.c:622)
> ==23402==    by 0x40034AF: dl_main (rtld.c:1683)
> ==23402==    by 0x4016978: _dl_sysdep_start (dl-sysdep.c:249)
> ==23402==    by 0x4004C28: _dl_start_final (rtld.c:307)
> ==23402==    by 0x4004C28: _dl_start (rtld.c:413)
> ==23402==    by 0x4000C47: ??? (in /lib64/ld-2.22.so)
> 
> Expected Results:  
> valgrind running the application
>

Thanks, but this sort of report needs to go upstream.
Comment 2 Török Edwin 2016-04-29 14:13:02 UTC
I found a bug from 2013 on valgrind's bug tracker describing this problem.
Comment 3 Maciej S. Szmigiero 2016-12-15 14:35:22 UTC
I have also hit this problem.

It basically means that valgrind is currently unusable for anybody that has glibc compiled with "-march" set to any CPU supporting TBM instruction set.

In upstream bugzilla ( https://bugs.kde.org/show_bug.cgi?id=322586 - a different report from one mentioned in comment 2) there is a proposed patch (from 2013).
With this patch applied to current valgrind it works fine for me.

Since upstream is a bit slow fixing this it would be a good thing to ship this patch, at least as a temporary measure.
Comment 4 Ștefan Talpalaru 2020-05-16 01:23:28 UTC
A patched valgrind-3-15-0-r1 is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay

Ported patch also attached to the upstream bug: https://bugs.kde.org/show_bug.cgi?id=381819
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-25 12:06:22 UTC
While it's tempting to Just Apply It, I'd much rather get blueness' take here. Any thoughts.
Comment 6 Andreas K. Hüttel archtester gentoo-dev 2023-09-04 20:42:06 UTC
Version is long gone
Comment 7 Ștefan Talpalaru 2023-09-04 23:11:34 UTC
valgrind-3.21.0 still has this problem and the patch is still required.