Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 562926 - =dev-libs/STLport-5.2.1-r3 stabilization request
Summary: =dev-libs/STLport-5.2.1-r3 stabilization request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: C++ Team [disbanded]
URL:
Whiteboard: WAS: dev-libs/STLport-5.2.1-r1 - src/...
Keywords: PATCH, STABLEREQ
Depends on:
Blocks:
 
Reported: 2015-10-12 13:39 UTC by uzu
Modified: 2016-01-09 06:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch adding __USE_MISC conditional to src/time_facets.cpp (14_add_access_tm_gmtoff_via_use_misc.patch,484 bytes, patch)
2015-10-12 13:41 UTC, uzu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description uzu 2015-10-12 13:39:59 UTC
time_facets.cpp accesses __tm_gmtoff when neither __USE_BSD or __BEOS__ are defined but time.h only grants access when __USE_MISC is undefined.

Building fails both with the vanilla source just as with both -r1 and -r2 in the gentoo repo so none of the present patches attend to this issue.

Reproducible: Always

Actual Results:  
x86_64-pc-linux-gnu-g++  -fexceptions  -fPIC   -fvisibility=hidden -O1 -Wformat=2 -march=native  -D_GNU_SOURCE -I../../stlport  -c -o obj/gcc/so/numpunct.o ../../src/numpunct.cpp
x86_64-pc-linux-gnu-g++  -fexceptions  -fPIC   -fvisibility=hidden -O1 -Wformat=2 -march=native  -D_GNU_SOURCE -I../../stlport  -c -o obj/gcc/so/time_facets.o ../../src/time_facets.cpp
x86_64-pc-linux-gnu-g++  -fexceptions  -fPIC   -fvisibility=hidden -O1 -Wformat=2 -march=native  -D_GNU_SOURCE -I../../stlport  -c -o obj/gcc/so/messages.o ../../src/messages.cpp
../../src/time_facets.cpp: In function 'void stlp_std::priv::__write_formatted_timeT(stlp_std::priv::__basic_iostring<_CharT>&, const stlp_std::ctype<_CharT>&, char, char, const _TimeInfo&, const tm*)':
../../src/time_facets.cpp:434:19: error: 'const struct tm' has no member named '__tm_gmtoff'
         diff = t->__tm_gmtoff;
                   ^
../Makefiles/gmake/targets.mak:123: recipe for target 'obj/gcc/so/time_facets.o' failed
make[1]: *** [obj/gcc/so/time_facets.o] Error 1
make[1]: *** Waiting for unfinished jobs....



Portage 2.2.23 (python 3.4.3-final-0, hardened/linux/amd64/selinux, gcc-4.9.3-vanilla, glibc-2.21-r1, 4.1.0 x86_64)
Timestamp of repository gentoo: Sun, 11 Oct 2015 23:30:01 +0000
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
ccache version 3.2.4 [disabled]
app-shells/bash:          4.3_p42::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.22.0::gentoo
dev-lang/python:          2.7.10::gentoo, 3.3.5-r2::gentoo, 3.4.3::gentoo
dev-util/ccache:          3.2.4::gentoo
dev-util/cmake:           3.3.2::gentoo
dev-util/pkgconfig:       0.29::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.18::gentoo
sys-apps/sandbox:         2.9::gentoo
sys-devel/autoconf:       2.69-r1::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.13.4::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo, 5.2.0::gentoo
sys-devel/gcc-config:     1.8::gentoo
sys-devel/libtool:        2.4.6-r1::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.2::gentoo (virtual/os-headers)
sys-libs/glibc:           2.21-r1::gentoo

ABI="amd64"
ABI_X86="64"
ARCH="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -Wformat=2 -g -O1"
CFLAGS_amd64="-m64"
CFLAGS_x32="-mx32"
CFLAGS_x86="-m32"
CHOST="x86_64-pc-linux-gnu"
CHOST_amd64="x86_64-pc-linux-gnu"
CHOST_x32="x86_64-pc-linux-gnux32"
CHOST_x86="i686-pc-linux-gnu"
CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 sse4_1 ssse3"
DEFAULT_ABI="amd64"
ELIBC="glibc"
EPREFIX=""
EROOT="/"
HOME="/home/fuiton"
IUSE_IMPLICIT="abi_x86_64 prefix prefix-guest"
KERNEL="linux"
LANG="en_US.UTF-8"
LC_MESSAGES="C"
LDFLAGS=""
LDFLAGS_amd64="-m elf_x86_64"
LDFLAGS_x32="-m elf32_x86_64"
LDFLAGS_x86="-m elf_i386"
LINGUAS="en"
MAKEOPTS="-j3"
MULTILIB_ABIS="amd64 x86"
POLICY_TYPES="strict"
PORTAGE_SANDBOX_T="portage_sandbox_t"
PORTAGE_WORKDIR_MODE="0700"
PORTAGE_XATTR_EXCLUDE="btrfs.* security.evm security.ima 	security.selinux system.nfs4_acl"
PRELINK_PATH_MASK="/usr/lib64/libfreebl3.so:/usr/lib64/libnssdbm3.so:/usr/lib64/libsoftokn3.so"
PROFILE_IS_HARDENED="1"
SYMLINK_LIB="yes"
USERLAND="GNU"
Comment 1 uzu 2015-10-12 13:41:48 UTC
Created attachment 414442 [details, diff]
Patch adding __USE_MISC conditional to src/time_facets.cpp
Comment 2 Sergey Popov gentoo-dev 2015-11-07 11:59:07 UTC
commit 11274bcec2d735bbf1b3c9c79b2e1a6c6f347628
Author: Sergey Popov <pinkbyte@gentoo.org>
Date:   Sat Nov 7 14:55:43 2015 +0300

    dev-libs/STLport: fix accessing to tm struct during build
    
    time_facets.cpp misses _USE_MISC check, which makes building failed
    Fixed by adding a proper check. Drop old revision.
    
    Suggested-by: uzu@tuta.io
    Gentoo-Bug: 562926
    
    Package-Manager: portage-2.2.24


As current stable is broken, i will turn this bug into stabilization request.

Arches, please test and mark stable =dev-libs/STLport-5.2.1-r3

Target keywords: amd64 ppc ppc64 sparc x86
Comment 3 Agostino Sarubbo gentoo-dev 2015-11-09 10:33:59 UTC
amd64 stable
Comment 4 Agostino Sarubbo gentoo-dev 2015-11-11 09:15:04 UTC
x86 stable
Comment 5 Agostino Sarubbo gentoo-dev 2015-11-12 09:40:43 UTC
ppc stable
Comment 6 Agostino Sarubbo gentoo-dev 2015-11-13 09:43:24 UTC
ppc64 stable
Comment 7 Agostino Sarubbo gentoo-dev 2016-01-09 06:44:10 UTC
sparc stable. Closing.