556822 – git-r3.eclass: support git repos hosted in gerrit (sandbox & changes namespaces)

Bug 556822 - git-r3.eclass: support git repos hosted in gerrit (sandbox & changes namespaces)

Summary: git-r3.eclass: support git repos hosted in gerrit (sandbox & changes namespaces)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Michał Górny

URL:	https://chromium-review.googlesource....
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-08-06 09:10 UTC by SpanKY
Modified:	2015-11-29 10:04 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description SpanKY gentoo-dev

2015-08-06 09:10:32 UTC

in CrOS we had to tweak git-r3.eclass to support gerrit namespaces.  specifically, it uses refs/sandbox/* and refs/changes/* to host commits in addition to refs/heads/*.  but rather than hardcode these additional things, we inverted the check to accept all refs/* except refs/tags/* explicitly.

patch is here:
https://chromium-review.googlesource.com/#/c/281396/2/eclass/git-r3.eclass

Comment 1 Michał Górny archtester

2015-08-06 09:19:58 UTC

Hmm, I wonder if we could make it even simpler and limit it to [[ != refs/tags/* ]].

Comment 2 Michał Górny archtester

2015-09-22 20:50:08 UTC

Either I'm missing something or your patch is done against some ancient version of the eclass.

Comment 3 SpanKY gentoo-dev

2015-09-22 21:43:08 UTC

it most likely is, but the point wasn't really to merge it directly, but to use as a reference point of what we needed/wanted

Comment 4 Michał Górny archtester

2015-09-26 13:29:40 UTC

Patches sent for review.

Comment 5 Michał Górny archtester

2015-11-29 10:04:12 UTC

Merged.