Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 555058 - app-admin/testdisk incorrectly uses :* deps
Summary: app-admin/testdisk incorrectly uses :* deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nicolas Bock
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-16 09:03 UTC by josef.95
Modified: 2015-08-30 21:15 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
testdisk-7.0-r2.ebuild.patch (testdisk-7.0-r2.ebuild.patch,427 bytes, patch)
2015-07-16 09:03 UTC, josef.95
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description josef.95 2015-07-16 09:03:29 UTC
Created attachment 406906 [details, diff]
testdisk-7.0-r2.ebuild.patch

From testdisk-7.0-r2.ebuild
qt4? ( >=dev-qt/qtgui-4.0.1:* )

This would install dev-qt/qtgui (and deps) from slot 5
The attached patch would prevent.

Thanks
Comment 1 Michael Palimaka (kensington) gentoo-dev 2015-08-22 06:49:35 UTC
@Nicolas, I think you made these changes.

:* means that any SLOT will satisfy the dependency, which is not a particularly common case.

There's three uses of this across the various testdisk ebuilds:

app-forensics/libewf:* - there is only one SLOT of libewf currently but we don't know what the future might hold. Since libewf defines a subslot, it's likely you want := (or :0=) instead.

>=dev-qt/qtgui-4.0.1:* - it's unlikely that the package will build with Qt 5 too. I suggest dev-qt/qtgui:4 instead.

virtual/jpeg:* - this package has different SLOTs for compatibility with binary packages. Only SLOT 0 provides headers, so unless this is a binary package you want virtual/jpeg:0.
Comment 2 Nicolas Bock gentoo-dev 2015-08-22 11:57:17 UTC
I have pushed app-admin/testdisk-6.14-r2 and app-admin/testdisk-7.0-r3 to address this. Thanks josef.95 for noticing this problem!

And thanks Michael for walking me through the correct use of slot operators. I had not fully understood how to use them correctly at the time I committed the ebuilds. Thanks!
Comment 3 josef.95 2015-08-30 18:58:31 UTC
It works fine for me.

Thank you :)
Comment 4 Nicolas Bock gentoo-dev 2015-08-30 21:15:16 UTC
Closing.