Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550298 - sys-libs/libcap-ng: utils/proc-llist.c fails to include <unistd.h> and breaks build on sys-libs/musl.
Summary: sys-libs/libcap-ng: utils/proc-llist.c fails to include <unistd.h> and breaks...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Hardened (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL: https://bugzilla.redhat.com/show_bug....
Whiteboard:
Keywords:
Depends on: 556872
Blocks: musl-porting
  Show dependency tree
 
Reported: 2015-05-24 13:36 UTC by Shiz
Modified: 2015-10-04 22:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shiz 2015-05-24 13:36:11 UTC 
Currently when attempting to perform a stage 3 install from the latest experimental/hardened/musl/amd64 tarball, an emerge -NuD world fails because the main tree ships sys-libs/libcap-ng 0.7.4 as stable. The hardened-dev overlay with musl patches still ships 0.7.3, thus Portage will prefer and attempt to install the main tree version, which will then fail.

An alternative solution would be to add >=sys-libs/libcap-ng-0.7.4 to the hardened/linux/musl profiles' package.mask until the patches are forward-ported to 0.7.4, if that turns out to be nontrivial.
Comment 1 Anthony Basile gentoo-dev 2015-05-24 14:35:56 UTC 
I've bumped this on the overlay, but the patch should go upstream.  Its trivial and POSIX-correct.  It adds #include <unistd.h> for pid_t and uid_t.  I've looked at http://people.redhat.com/sgrubb/libcap-ng/ bug I can't find any bug reporting process.

Does anyone in base-system know?  Do I just submit at https://bugzilla.redhat.com/?
Comment 2 Shiz 2015-05-24 14:58:51 UTC 
Judging from earlier bugs[1][2], https://bugzilla.redhat.com seems to be the place to go.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=895105
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=650594
Comment 3 SpanKY gentoo-dev 2015-05-25 01:42:24 UTC 
(In reply to Anthony Basile from comment #1)

where is the patch ?
Comment 4 Shiz 2015-05-25 01:47:04 UTC 
Presumably, he means the patch in the hardened-development overlay[1].

[1]: https://gitweb.gentoo.org/proj/hardened-dev.git/tree/sys-libs/libcap-ng/files/libcap-ng-0.7.3-add-missing-unistd_h.patch?h=musl
Comment 5 SpanKY gentoo-dev 2015-05-25 02:11:10 UTC 
(In reply to Shiz from comment #4)

that patch is fine for the main tree once it's cleaned & properly documented:
  https://dev.gentoo.org/~vapier/clean-patches
Comment 6 Anthony Basile gentoo-dev 2015-05-26 10:45:11 UTC 
The patch is now in the our tree for libcap-ng-0.7.5 (not previous)

https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-libs/libcap-ng/files/libcap-ng-0.7.5-add-unistd_h.patch?revision=1.1&view=markup

and it is submitted upstream at the above URL.
Comment 7 Anthony Basile gentoo-dev 2015-05-27 22:59:40 UTC 
Upstream says the fix is in 0.7.7.  I'll bump and see if it works.
Comment 8 Anthony Basile gentoo-dev 2015-05-28 01:17:03 UTC 
(In reply to Anthony Basile from comment #7)
> Upstream says the fix is in 0.7.7.  I'll bump and see if it works.

It works.  I bumped 0.7.6 (with my patch) and 0.7.7 (without my patch) to the tree.  The next version of libcap-ng to stabilize should be 0.7.7.
Comment 9 tt_1 2015-10-04 07:27:26 UTC 
can be closed, 0.7.7 is stable on all related archs.