Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544662 - cmake-utils.eclass - gentoo_toolchain.cmake should set CMAKE_RC_COMPILER
Summary: cmake-utils.eclass - gentoo_toolchain.cmake should set CMAKE_RC_COMPILER
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-27 13:44 UTC by Michael Seifert
Modified: 2015-10-15 11:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
cmake-utils.eclass-cmake-rc-compiler.patch (cmake-utils.eclass-cmake-rc-compiler.patch,460 bytes, patch)
2015-03-27 13:46 UTC, Michael Seifert 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Seifert 2015-03-27 13:44:20 UTC 
When cross-compiling a CMake project, cmake-utils.eclass creates an appropriate toolchain file which specifies CC, CXX, and so forth. When compiling for Windows (e.g. x86_64-w64-mingw32 target), CMake needs to know about CMAKE_RC_COMPILER, which is not set in the toolchain file.

Reproducible: Always

Actual Results:  
CMAKE_RC_COMPILER is unset

Expected Results:  
CMAKE_RC_COMPILER should contain the full path to the windres executable.
Comment 1 Michael Seifert 2015-03-27 13:46:20 UTC 
Created attachment 399876 [details, diff]
cmake-utils.eclass-cmake-rc-compiler.patch

Sets CMAKE_RC_COMPILER, if the KERNEL is "Winnt".
Comment 2 Michael Palimaka (kensington) gentoo-dev 2015-03-27 14:29:32 UTC 
CCing prefix if they have any comment.
Comment 3 Michael Seifert 2015-05-27 08:41:30 UTC 
Seems like the prefix project does not have any comments :)
Comment 4 Fabian Groffen gentoo-dev 2015-05-27 11:04:02 UTC 
nope, looks ok to me
Comment 5 Michael Palimaka (kensington) gentoo-dev 2015-05-27 12:24:31 UTC 
In overlay: https://gitweb.gentoo.org/proj/kde.git/commit/?id=9f31193e80fb5ea68e7112b7378be37afc00cf80
Comment 6 Michael Seifert 2015-05-27 14:42:34 UTC 
Great, thanks!
Comment 7 Johannes Huber (RETIRED) gentoo-dev 2015-07-17 21:37:35 UTC 
(In reply to Michael Palimaka (kensington) from comment #5)
> In overlay:
> https://gitweb.gentoo.org/proj/kde.git/commit/
> ?id=9f31193e80fb5ea68e7112b7378be37afc00cf80

Can we move it to the tree?
Comment 8 Michael Palimaka (kensington) gentoo-dev 2015-07-18 13:55:22 UTC 
(In reply to Johannes Huber from comment #7)
> Can we move it to the tree?

I guess so.
Comment 9 Michael Palimaka (kensington) gentoo-dev 2015-10-15 11:25:26 UTC 
Thanks, fixed in git.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d09e4e1ff25830792c9201ba5e52516cfe008b25