Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544032 - sys-block/parted: fix includes to enable compiling against musl
Summary: sys-block/parted: fix includes to enable compiling against musl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Hardened (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: musl-porting
  Show dependency tree
 
Reported: 2015-03-21 15:52 UTC by Travis Tilley
Modified: 2019-07-13 23:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix compilation against musl (0001-sys-block-parted-fix-includes-to-allow-compiling-aga.patch,7.90 KB, patch)
2015-03-21 15:52 UTC, Travis Tilley
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Travis Tilley 2015-03-21 15:52:45 UTC
Created attachment 399390 [details, diff]
fix compilation against musl

parted fails to compile against musl's headers. it appears to assume fnctl.h will be pulled in as a side effect of another include. 

fix attached. i didn't bump the ebuild revision but since this has never compiled against musl before and there isn't an existing ebuild in the musl overlay.
Comment 1 Travis Tilley 2015-03-21 15:53:46 UTC
since this is a really simple patch, and i dont see how this could cause any problems, it should probably land directly in the main tree rather than sit in the overlay IMHO.
Comment 2 Travis Tilley 2015-03-21 15:55:48 UTC
seriously, the patch is just to add '#include <fnctl.h>' to 'libparted/fs/xfs/platform_defs.h'.
Comment 3 Felix Janda 2015-03-21 16:22:23 UTC
Looks fine for upstream.

http://lists.alioth.debian.org/mailman/listinfo/parted-devel

seems to be the list (unfortunately subscriber only) where to send your
patch to. Preferably use git-send-email and say in the message why the
include is necessary.
Comment 4 Anthony Basile gentoo-dev 2015-05-13 17:47:40 UTC
Has anyone sent this usptream?
Comment 7 Jory A. Pratt gentoo-dev 2019-07-13 23:36:25 UTC
Current in tree version works with musl