543328 – app-office/libreoffice-bin: do not always require gtk2

Bug 543328 - app-office/libreoffice-bin: do not always require gtk2

Summary: app-office/libreoffice-bin: do not always require gtk2

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Andreas K. Hüttel

URL:
Whiteboard:
Keywords:

Depends on:	589284
Blocks:
	Show dependency tree

Reported:	2015-03-14 16:20 UTC by Dainius Masiliūnas
Modified:	2019-02-28 17:24 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dainius Masiliūnas 2015-03-14 16:20:06 UTC

Currently, the libreoffice-bin ebuild unconditionally pulls in gtk+:2. However, there's no reason to do that as far as I know, since LibreOffice uses VCL, which currently supports GTK2, GTK3, Qt3, Qt4 and plain X11 backends.

Reproducible: Always

Steps to Reproduce:
1. USE="kde -gtk -gtk3" emerge -pv libreoffice-bin
Actual Results:  
gtk+:2 gets pulled in

Expected Results:  
Only Qt4 should be pulled in

In the source ebuild, the gtk+:2 requirement is behind a "gtk" USE flag, the gtk+:3 requirement is behind a "gtk3" USE flag, and Qt4 is pulled in via the "kde" USE flag. The same scheme should be possible to use in -bin as well.

Comment 1 Andreas K. Hüttel archtester

2016-07-03 18:30:59 UTC

gtk2 is indeed even now still hard-required for the gtk3 build.commit d651c2adc4cd999ecbb4035c83630274445fab0e
Author: Andreas K. Hüttel <dilfridge@gentoo.org>
Date:   Sun Jul 3 20:30:36 2016 +0200

    Explicitly enable gtk only in gnome profile, bug 543328

 generate | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 2 Andreas K. Hüttel archtester

2016-07-20 22:17:44 UTC

Fixed in 5.1.4.2

Comment 3 Arnaud Vallette d'Osia 2019-02-28 17:24:59 UTC

I feel we should reopen this one :
libreoffice-bin hard depends on gtk2 still?